Avoid modifying the PATH for the python test suites#308
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #308 +/- ##
========================================
Coverage 84.70% 84.70%
========================================
Files 17 17
Lines 2230 2230
========================================
Hits 1889 1889
Misses 341 341
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…nstead of modifying the system PATH
bigspider
force-pushed
the
pythonpath
branch
from
c35e8d4 to
bf12689
Compare
Co-authored-by: lpascal-ledger <lucas.pascal@ledger.com>
lpascal-ledger
approved these changes
Jan 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead, install the local
ledger_bitcoinpackage as part of therequirements.txt.Moved all the various
requirements.txtto a single file in the root of the repo.Closes: #307