Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #316 +/- ##
========================================
Coverage 84.70% 84.70%
========================================
Files 17 17
Lines 2230 2230
========================================
Hits 1889 1889
Misses 341 341
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
… and sign_sighash_schnorr_and_yield
…of sign_psbt. Created separate utility modules instead. Deleted the 'update_hashes_with_map_value' module, as it was only used in the new txhashes.c module. Cleaned up interface of the various compute_sighash_* functions. Avoid taking the key placeholder as an argument, and declare some of the arguments as const pointers.
…functions public. The functions (and some related ones) have been refactored in order to avoid arguments referring to the specific input state, or the key expression.
iartemov-ledger
approved these changes
Mar 13, 2025
Contributor
iartemov-ledger
left a comment
iartemov-ledger
left a comment
There was a problem hiding this comment.
I have not compared the functions moved from sign_psbt.c.
Also you mentioned some bitcoin flavors that would benefit from this refactoring. Do we test them somewhere?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes from #314 that are relevant improvement for the
developbranch.It's mostly about cleaning up some interfaces, modularizing and exposing some previously static functionality