Skip to content

Clang 21 migration#427

Merged
iartemov-ledger merged 4 commits intodevelopfrom
clang_21_migration
Mar 2, 2026
Merged

Clang 21 migration#427
iartemov-ledger merged 4 commits intodevelopfrom
clang_21_migration

Conversation

@iartemov-ledger
Copy link
Contributor

@iartemov-ledger iartemov-ledger commented Feb 23, 2026

  • Fixing LEDGER_ASSERT failures with strings exceeding internal MESSAGE_SIZE hard-coded to 50
  • Removing unused key_expression_index variable
  • Fixing count_m variable use
    • A non-regression UT

@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.81%. Comparing base (1fdcbd7) to head (e20c3a5).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #427   +/-   ##
========================================
  Coverage    85.81%   85.81%           
========================================
  Files           18       18           
  Lines         2812     2813    +1     
  Branches       425      426    +1     
========================================
+ Hits          2413     2414    +1     
  Misses         388      388           
  Partials        11       11           
Flag Coverage Δ
unittests 85.81% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@iartemov-ledger iartemov-ledger marked this pull request as ready for review February 23, 2026 15:56
Copy link
Collaborator

@bigspider bigspider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iartemov-ledger iartemov-ledger merged commit 89c9da5 into develop Mar 2, 2026
231 of 236 checks passed
@iartemov-ledger iartemov-ledger deleted the clang_21_migration branch March 2, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants