Skip to content

enable stack protector#212

Merged
mbrousset-ledger merged 2 commits into
masterfrom
mbr/sp
Jun 11, 2026
Merged

enable stack protector#212
mbrousset-ledger merged 2 commits into
masterfrom
mbr/sp

Conversation

@mbrousset-ledger

@mbrousset-ledger mbrousset-ledger commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Checklist

  • App update process has been followed
  • Target branch is develop
  • Application version has been bumped
$ find build -type f -name 'app.elf' | xargs -I{} bash -c "echo {}; nm {} | grep 'stack'"
build/stax/bin/app.elf
da7a0de4 B app_stack_canary
da7a9000 B _estack
da7a0de8 B _stack
da7a0000 B __stack_chk_guard
c0deabd1 T __wrap___stack_chk_fail
c0de0001 T __wrap___stack_chk_init
build/apex_p/bin/app.elf
da7a0de4 B app_stack_canary
da7aa000 B _estack
da7a0de8 B _stack
da7a0000 B __stack_chk_guard
c0dea9dd T __wrap___stack_chk_fail
c0de0001 T __wrap___stack_chk_init
build/nanox/bin/app.elf
da7a09a8 B app_stack_canary
da7a7000 B _estack
da7a09ac B _stack
da7a0000 B __stack_chk_guard
c0de6519 T __wrap___stack_chk_fail
c0de0001 T __wrap___stack_chk_init
build/nanos2/bin/app.elf
da7a0990 B app_stack_canary
da7aa000 B _estack
da7a0994 B _stack
da7a0000 B __stack_chk_guard
c0de649d T __wrap___stack_chk_fail
c0de0001 T __wrap___stack_chk_init
build/flex/bin/app.elf
da7a0de4 B app_stack_canary
da7a9000 B _estack
da7a0de8 B _stack
da7a0000 B __stack_chk_guard
c0deab11 T __wrap___stack_chk_fail
c0de0001 T __wrap___stack_chk_init

@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.44%. Comparing base (360e815) to head (1a17816).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #212   +/-   ##
=======================================
  Coverage   72.44%   72.44%           
=======================================
  Files           5        5           
  Lines          98       98           
  Branches       22       22           
=======================================
  Hits           71       71           
  Misses          9        9           
  Partials       18       18           
Flag Coverage Δ
unittests 72.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mbrousset-ledger mbrousset-ledger marked this pull request as ready for review June 11, 2026 17:30
Copilot AI review requested due to automatic review settings June 11, 2026 17:30
@mbrousset-ledger mbrousset-ledger requested a review from a team as a code owner June 11, 2026 17:30
@mbrousset-ledger mbrousset-ledger requested review from cedelavergne-ledger and removed request for a team June 11, 2026 17:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables stack protection in the app build configuration (and bumps the patch version) so produced binaries include stack canary/stack-check support as part of the standard build.

Changes:

  • Bump application patch version from 2.3.1 to 2.3.2.
  • Enable stack protection by setting ENABLE_STACK_PROTECTOR in the main Makefile.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Makefile Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Code coverage report

Code Coverage

Per-file coverage
Package Line Rate Branch Rate Health
src.transaction 85% 58%
Summary 85% (50 / 59) 58% (28 / 48)

@mbrousset-ledger mbrousset-ledger merged commit 383782c into master Jun 11, 2026
111 checks passed
@mbrousset-ledger mbrousset-ledger deleted the mbr/sp branch June 11, 2026 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants