fix segv

.gitignore

@@ -6,6 +6,7 @@ debug/
 dep/
 obj/
 build/
+.vscode/settings.json
 
 # Unit tests and code coverage
 unit-tests/build/

Makefile

@@ -22,7 +22,7 @@
 # Application version
 APPVERSION_M = 0
 APPVERSION_N = 1
-APPVERSION_P = 1
+APPVERSION_P = 2
 APPVERSION = "$(APPVERSION_M).$(APPVERSION_N).$(APPVERSION_P)"
 
 # Setting to allow building variant applications

src/display.c

@@ -16,17 +16,18 @@ static void review_choice(bool approved) {
     }
 }
 
-#define MAX_N_PAIRS 4;
+#define MAX_N_PAIRS 4
+
+// These are kept static rather than on the stack because the NBGL library
+// stores pointers to them that must remain valid long term.
+static nbgl_layoutTagValue_t pairs[MAX_N_PAIRS];
+static nbgl_layoutTagValueList_t pairList;
+static char value_str[32], magic_value_str[32], fee_str[32];
 
 bool display_transaction(dispatcher_context_t *dc,
                          int64_t value_spent,
                          uint64_t magic_input_value,
                          uint64_t fee) {
-    nbgl_layoutTagValue_t pairs[4];
-    nbgl_layoutTagValueList_t pairList;
-
-    // format value_spent
-    char value_str[32], magic_value_str[32], fee_str[32];
     uint64_t value_spent_abs = value_spent < 0 ? -value_spent : value_spent;
     format_sats_amount(COIN_COINID_SHORT, value_spent_abs, value_str);
     format_sats_amount(COIN_COINID_SHORT, magic_input_value, magic_value_str);

src/main.c

@@ -106,7 +106,8 @@ static bool validate_transaction(dispatcher_context_t *dc,
                                                     sizeof(witness_utxo))) {
         PRINTF("Failed to get witness utxo, or invalid witness utxo\n");
         SEND_SW(dc, SW_INCORRECT_DATA);
-    };
+        return false;
+    }
     if (witness_utxo[8] != 34) {
         PRINTF("Unexpected scriptPubKey length in witness utxo: %d\n", witness_utxo[8]);
         SEND_SW(dc, SW_INCORRECT_DATA);