fix: Out-of-bounds read from unbounded NodeSeed.seed in prepared transaction signing - #41
Merged
Merged
Conversation
added 2 commits
April 15, 2026 09:56
Automated CI remediation by Cerberus Merlin.
agrojean-ledger
previously approved these changes
Apr 23, 2026
agrojean-ledger
left a comment
Collaborator
There was a problem hiding this comment.
Checking seed presence and length is warranted.
encode_hash on the seed unconditionally reads exactly SHA256_HASH_LEN bytes from whatever pointer is passed. So enforcing the length when decoding the serialized transaction is relevant.
agrojean-ledger
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Automated security fix for Out-of-bounds read from unbounded NodeSeed.seed in prepared transaction signing (High).
CWE: CWE-CWE-125
OWASP: A03:2021-Injection
Fix Confidence: high
What Changed
Validated node seed presence and length before hashing in prepared transaction node parsing. Create nodes now reject malformed matching seeds, and exercise nodes now reject missing or malformed seeds before any 32-byte hash encoding can read past the protobuf allocation.
Caveats
Verification Checklist
Created by Cerberus Merlin