fix: Silent fallback from BUNDLED PARAM_GROUP to sequential rendering in Generic Transaction Parser#1010
Merged
Merged
Conversation
… in Generic Transaction Parser
6947ae8 to
b41cb1b
Compare
cedelavergne-ledger
previously approved these changes
May 11, 2026
Contributor
|
elf sizes
Stack consumption summary (clone_app_stack_consumption)
Stack consumption summary
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1010 +/- ##
===========================================
- Coverage 56.10% 56.04% -0.06%
===========================================
Files 26 26
Lines 2417 2414 -3
Branches 312 323 +11
===========================================
- Hits 1356 1353 -3
- Misses 979 1057 +78
+ Partials 82 4 -78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Automated security fix for Silent fallback from BUNDLED PARAM_GROUP to sequential rendering in Generic Transaction Parser (High).
CWE: CWE-CWE-451
OWASP: A04:2021-Insecure Design
Fix Confidence: high
What Changed
Replaced the silent fallback from BUNDLED to SEQUENTIAL rendering with a hard failure. When a PARAM_GROUP descriptor specifies GROUP_ITER_BUNDLED (or defaults to it), format_param_group now returns false, aborting clear-signing rather than displaying fields in an order that diverges from the signed metadata.
Caveats
Verification Checklist
Created by Cerberus Merlin