Skip to content

docs: Clarify address format in APDU docs#762

Merged
apaillier-ledger merged 1 commit into
LedgerHQ:developfrom
mertwole:docs/clarify-public-key-encoding-in-apdu-docs
Apr 8, 2025
Merged

docs: Clarify address format in APDU docs#762
apaillier-ledger merged 1 commit into
LedgerHQ:developfrom
mertwole:docs/clarify-public-key-encoding-in-apdu-docs

Conversation

@mertwole
Copy link
Copy Markdown
Contributor

Description

Clarify that GET ETH PUBLIC ADDRESS APDU request returns ASCII-encoded address

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@apaillier-ledger
Copy link
Copy Markdown
Contributor

Thanks for the PR @mertwole ! 👍

@apaillier-ledger apaillier-ledger merged commit d7f34d1 into LedgerHQ:develop Apr 8, 2025
195 of 196 checks passed
@mertwole mertwole deleted the docs/clarify-public-key-encoding-in-apdu-docs branch April 8, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants