Skip to content

EIP-712 memory allocator migration#822

Merged
apaillier-ledger merged 6 commits into
developfrom
feat/apa/eip712_allocator_migration
Jun 24, 2025
Merged

EIP-712 memory allocator migration#822
apaillier-ledger merged 6 commits into
developfrom
feat/apa/eip712_allocator_migration

Conversation

@apaillier-ledger
Copy link
Copy Markdown
Contributor

Description

Follow up to #792

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@apaillier-ledger apaillier-ledger force-pushed the feat/apa/eip712_allocator_migration branch from 2204482 to 1f70516 Compare June 19, 2025 12:59
Comment thread src_features/signMessageEIP712/typed_data.h Fixed
@apaillier-ledger apaillier-ledger force-pushed the feat/apa/eip712_allocator_migration branch 3 times, most recently from 090f358 to 797d6c5 Compare June 19, 2025 13:49
@apaillier-ledger apaillier-ledger marked this pull request as ready for review June 19, 2025 14:04
Comment thread src_features/signMessageEIP712/path.c Outdated
Comment thread src_features/signMessageEIP712/ui_logic.c Outdated
Comment thread src_features/signMessageEIP712/ui_logic.c
Comment thread src_features/signMessageEIP712/ui_logic.c
Comment thread src/list.h
Comment thread src/list.c
Comment thread src/list.c
@cedelavergne-ledger
Copy link
Copy Markdown
Contributor

Despites everyone don't agree, I am really convinced the src/list.c should be moved to the SDK to be global, efficient, robust, and also deeply tested with unit-tests and fuzzing 😉

@apaillier-ledger apaillier-ledger force-pushed the feat/apa/eip712_allocator_migration branch from 797d6c5 to bb54721 Compare June 20, 2025 12:56
@apaillier-ledger apaillier-ledger force-pushed the feat/apa/eip712_allocator_migration branch from bb54721 to 37e3c9c Compare June 24, 2025 10:03
Copy link
Copy Markdown
Contributor

@cedelavergne-ledger cedelavergne-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still disagree with some answers... But let's go like this for the moment.

@apaillier-ledger apaillier-ledger merged commit 640b4ae into develop Jun 24, 2025
200 checks passed
@apaillier-ledger apaillier-ledger deleted the feat/apa/eip712_allocator_migration branch June 24, 2025 12:28
@apaillier-ledger apaillier-ledger mentioned this pull request Jun 24, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants