Security review 1.21.0#947
Closed
bboilot-ledger wants to merge 132 commits into
Closed
Conversation
Fix ERC-20 extra data length computation
Ignored during GCS, was causing a SIGSEGV.
…s_setting Fixed debug contracts setting impacting GCS flows
Internal plugins refactoring
Required to fully display 48-byte public keys
* Update linter cfg * Fix linter * Add gating support to python client * Refactor EIP712 return error codes * Add gating support * Adapt UI to Gated Signing * Adapt ragger tests * Add new snapshots * Replace all Blind Signind screens by the Gated version * Align snapshots to new Blind Signing wording
EIP-7002 support
EIP-7002 small cleanup
* Cleanup sources - Remove useless header file - Fix bit-field init - Fix parameters casting * Migrate to Generic Fuzzer
EIP-712 filtered flow - show network
- Add support for 'CHAIN_ID container path' - Add support for 'NETWORK formatter' - Add support for 'VISIBILE & CONSTRAINTS'
- CHAIN_ID container path - NETWORK formatter - VISIBILE & CONSTRAINTS
- Add workflow - Remove unused demo - Add coverage script - Add Unit Tests for NETWORK formatter - Add Unit Tests for PARAM_TRUSTED_NAME - Add Unit Tests for PARAM_RAW - Add Unit Tests for CONSTRAINTS
B2CA-2477: Add new formatters
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #947 +/- ##
=========================================
Coverage ? 51.60%
=========================================
Files ? 17
Lines ? 1771
Branches ? 232
=========================================
Hits ? 914
Misses ? 856
Partials ? 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bboilot-ledger
commented
Feb 11, 2026
| } eth2_deposit_parameters_t; | ||
|
|
||
| void eth2_plugin_call(int message, void *parameters) { | ||
| void eth2_plugin_call(eth_plugin_msg_t message, void *parameters) { |
Contributor
Author
There was a problem hiding this comment.
msg->parameter must be checked based on parameterOffset and parameter_size
| void swap_with_calldata_plugin_call(int message, void *parameters) { | ||
| void swap_with_calldata_plugin_call(eth_plugin_msg_t message, void *parameters) { | ||
| switch (message) { | ||
| case ETH_PLUGIN_INIT_CONTRACT: |
Contributor
Author
There was a problem hiding this comment.
msg->parameter must be checked based on parameterOffset and parameter_size
1.21.0 security review fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please provide a detailed description of what was done in this PR.
(And mentioned if linked to an issue docs)
Changes include
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it.
Additional comments
Please post additional comments in this section if you have them, otherwise delete it.