Skip to content

EIP-712 fixes#971

Merged
apaillier-ledger merged 9 commits into
developfrom
fix/apa/eip712
Mar 25, 2026
Merged

EIP-712 fixes#971
apaillier-ledger merged 9 commits into
developfrom
fix/apa/eip712

Conversation

@apaillier-ledger
Copy link
Copy Markdown
Contributor

Description

Various EIP-712 fixes.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.02%. Comparing base (db1b4de) to head (ac12acb).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #971   +/-   ##
========================================
  Coverage    55.02%   55.02%           
========================================
  Files           16       16           
  Lines         1592     1592           
  Branches       201      195    -6     
========================================
  Hits           876      876           
+ Misses         712      699   -13     
- Partials         4       17   +13     
Flag Coverage Δ
unittests 55.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@apaillier-ledger apaillier-ledger marked this pull request as ready for review March 25, 2026 17:48
@apaillier-ledger apaillier-ledger merged commit 606aa03 into develop Mar 25, 2026
348 of 356 checks passed
@apaillier-ledger apaillier-ledger deleted the fix/apa/eip712 branch March 25, 2026 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants