Fbe/fix tx simulation issues#972
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #972 +/- ##
========================================
Coverage 55.02% 55.02%
========================================
Files 16 16
Lines 1592 1592
Branches 201 201
========================================
Hits 876 876
Misses 712 712
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR fixes TX simulation parsing/validation edge cases (notably max-length string fields) and tightens the TX simulation TLV schema handling.
Changes:
- Add an integration test covering spec-maximum
provider_message(25 chars) andtiny_url(30 chars). - Fix printable-string extraction bounds to allow max-length strings (incl. null terminator handling).
- Refactor TX simulation enums and TLV validation (type/risk/category ranges, clearer missing/unexpected tag handling, fallback to UNKNOWN on parameter mismatch).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| tests/ragger/test_tx_simulation.py | Adds a bounds test to ensure max-length provider/tiny-url strings are accepted. |
| src/tlv_apdu.c | Adjusts printable-string extraction to pass correct max length to TLV string helper. |
| src/features/provide_tx_simulation/cmd_get_tx_simulation.h | Updates TX simulation risk/type/category enums and struct typing. |
| src/features/provide_tx_simulation/cmd_get_tx_simulation.c | Updates TX simulation TLV parsing/validation and warning fallback behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
4cd41be to
fdc00cc
Compare
cedelavergne-ledger
approved these changes
Mar 27, 2026
fdc00cc to
9e7abe7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please provide a detailed description of what was done in this PR.
(And mentioned if linked to an issue docs)
Changes include