Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/workflows/build_and_functional_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,7 @@ on:
- 'Open a PR'
push:
branches:
- master
- main
- develop
- nanos
pull_request:

jobs:
Expand Down
40 changes: 0 additions & 40 deletions .github/workflows/cflite_cron.yml

This file was deleted.

43 changes: 0 additions & 43 deletions .github/workflows/cflite_pr.yml

This file was deleted.

37 changes: 4 additions & 33 deletions .github/workflows/codeql_checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@ on:
workflow_dispatch:
push:
branches:
- master
- main
- develop
- nanos
pull_request:
# Excluded path: add the paths you want to ignore instead of deleting the workflow
paths-ignore:
Expand All @@ -15,33 +13,6 @@ on:

jobs:
analyse:
name: Analyse
strategy:
fail-fast: false
matrix:
sdk: ["$NANOS_SDK", "$NANOX_SDK", "$NANOSP_SDK", "$STAX_SDK", "$FLEX_SDK"]
# 'cpp' covers C and C++
language: ['cpp']
runs-on: ubuntu-latest
container:
image: ghcr.io/ledgerhq/ledger-app-builder/ledger-app-builder-lite:latest

steps:
- name: Clone
uses: actions/checkout@v4
with:
submodules: true

- name: Initialize CodeQL
uses: github/codeql-action/init@v3
with:
languages: ${{ matrix.language }}
queries: security-and-quality

# CodeQL will create the database during the compilation
- name: Build
run: |
make BOLOS_SDK=${{ matrix.sdk }}

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v3
name: Call Ledger CodeQL analysis
uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_codeql_checks.yml@v1
secrets: inherit
19 changes: 4 additions & 15 deletions .github/workflows/codespell.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,23 +4,12 @@ on:
workflow_dispatch:
push:
branches:
- master
- main
- develop
- nanos
pull_request:

jobs:
misspell:
name: Check misspellings
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
submodules: true

- name: Check misspellings
uses: codespell-project/actions-codespell@v2
with:
builtin: clear,rare
check_filenames: true
path: src, src_bagl, src_features, src_nbgl, src_plugins, doc, client
uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_spell_check.yml@v1
with:
src_path: src, src_bagl, src_features, src_nbgl, src_plugins, doc, client
4 changes: 1 addition & 3 deletions .github/workflows/guidelines_enforcer.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,7 @@ on:
workflow_dispatch:
push:
branches:
- master
- main
- develop
- nanos
pull_request:

jobs:
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/lint-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,7 @@ on:
workflow_dispatch:
push:
branches:
- master
- main
- develop
- nanos
pull_request:

jobs:
Expand Down
17 changes: 0 additions & 17 deletions .github/workflows/swap-ci-workflow.yml

This file was deleted.

11 changes: 11 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,17 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning](http://semver.org/).

## [1.16.1](../../compare/1.16.0...1.16.1-lns) - 2026-03-30

### Fixed

- RLP elements parsing

### Removed

- 44'/1' derivation path
- 45' derivation path from clones

## [1.16.0](../../compare/1.15.0...1.16.0) - 2025-04-28

### Added
Expand Down
3 changes: 1 addition & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ include ./makefile_conf/chain/$(CHAIN).mk

APPVERSION_M = 1
APPVERSION_N = 16
APPVERSION_P = 0
APPVERSION_P = 1
APPVERSION = $(APPVERSION_M).$(APPVERSION_N).$(APPVERSION_P)

# Application source files
Expand Down Expand Up @@ -92,7 +92,6 @@ CURVE_APP_LOAD_PARAMS += secp256k1
# and SLIP-0044 standards.
# If your app needs it, you can specify multiple path by using:
# `PATH_APP_LOAD_PARAMS = "44'/1'" "45'/1'"`
PATH_APP_LOAD_PARAMS += "45'" "44'/1'"

# Setting to allow building variant applications
# - <VARIANT_PARAM> is the name of the parameter which should be set
Expand Down
2 changes: 1 addition & 1 deletion ledger_app.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[app]
build_directory = "./"
sdk = "C"
devices = ["nanos", "nanox", "nanos+", "stax", "flex"]
devices = ["nanos"]

[use_cases]
use_test_keys = "CAL_TEST_KEY=1 TRUSTED_NAME_TEST_KEY=1 SET_PLUGIN_TEST_KEY=1 NFT_TEST_KEY=1"
Expand Down
2 changes: 1 addition & 1 deletion makefile_conf/chain/ethereum.mk
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Lock the application on its standard path for 1.5. Please complain if non compliant
PATH_APP_LOAD_PARAMS += "44'/60'"
PATH_APP_LOAD_PARAMS += "44'/60'" "45'"
TICKER = "ETH"
CHAIN_ID = 1
# Allow to derive ETH 2 public keys
Expand Down
8 changes: 6 additions & 2 deletions src_features/signTx/ethUstream.c
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,9 @@ static bool processChainID(txContext_t *context) {
if (context->currentFieldPos < context->currentFieldLength) {
uint32_t copySize =
MIN(context->commandLength, context->currentFieldLength - context->currentFieldPos);
if (copyTxData(context, context->content->chainID.value, copySize) == false) {
if (copyTxData(context,
context->content->chainID.value + context->currentFieldPos,
copySize) == false) {
return false;
}
}
Expand All @@ -177,7 +179,9 @@ static bool processNonce(txContext_t *context) {
if (context->currentFieldPos < context->currentFieldLength) {
uint32_t copySize =
MIN(context->commandLength, context->currentFieldLength - context->currentFieldPos);
if (copyTxData(context, context->content->nonce.value, copySize) == false) {
if (copyTxData(context,
context->content->nonce.value + context->currentFieldPos,
copySize) == false) {
return false;
}
}
Expand Down
1 change: 1 addition & 0 deletions tests/ragger/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
pytest
ecdsa
web3~=6.0
speculos==0.25.5
ragger[speculos]
py_ecc
Loading