Make a SDK use_case for w3c#975
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #975 +/- ##
========================================
Coverage 56.04% 56.04%
========================================
Files 26 26
Lines 2414 2414
Branches 323 314 -9
========================================
Hits 1353 1353
+ Misses 1057 984 -73
- Partials 4 77 +73
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR introduces a new SDK-style TLV “use-case” parser for the Web3 Check (W3C) transaction simulation descriptor and refactors the existing transaction-simulation APDU handling to delegate parsing + PKI signature verification to this shared helper.
Changes:
- Added
tlv_use_case_w3c_check(C/H) implementing W3C TLV parsing, structural validation, and PKI signature verification. - Refactored
cmd_get_tx_simulationto call the new use-case and map its output into the existing Ethereum-specificTX_SIMULATIONstruct. - Updated tx-simulation types/constants to be backward-compatible aliases of the new W3C SDK types.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
src/features/provide_tx_simulation/tlv_use_case_w3c_check.h |
Declares W3C types, output struct, status codes, and the public parsing API. |
src/features/provide_tx_simulation/tlv_use_case_w3c_check.c |
Implements tag handlers, progressive hashing, structural checks, and PKI signature verification for W3C TLV payloads. |
src/features/provide_tx_simulation/cmd_get_tx_simulation.h |
Replaces legacy tx-simulation enums/sizes with aliases to the new W3C SDK definitions. |
src/features/provide_tx_simulation/cmd_get_tx_simulation.c |
Removes bespoke TLV parsing/signature code and delegates to the new W3C use-case, then copies output into the legacy global struct. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
e7d775d to
1fc2833
Compare
1fc2833 to
45b62e9
Compare
fb6c501 to
ab8d6da
Compare
ab8d6da to
f918bd8
Compare
f918bd8 to
1dfcf98
Compare
|
elf sizes
Stack consumption summary (clone_app_stack_consumption)
Stack consumption summary
|
1dfcf98 to
98b3479
Compare
98b3479 to
d15728b
Compare
Description
Make a SDK use_case for w3c
Changes include