Skip to content

Security review 1.22#977

Merged
apaillier-ledger merged 6 commits into
developfrom
security_review_1.22
Apr 7, 2026
Merged

Security review 1.22#977
apaillier-ledger merged 6 commits into
developfrom
security_review_1.22

Conversation

@bboilot-ledger
Copy link
Copy Markdown
Contributor

Description

Please provide a detailed description of what was done in this PR.
(And mentioned if linked to an issue docs)

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it.

Additional comments

Please post additional comments in this section if you have them, otherwise delete it.

Comment thread src/features/provide_nft_information/cmd_provide_nft_info.c Fixed
Comment thread src/features/sign_tx/rlp_utils.c Fixed
Comment thread src/features/sign_tx/rlp_utils.c Fixed
Comment thread src/features/provide_network_info/cmd_network_info.c
Comment thread src/features/provide_network_info/network_info.c
Comment thread src/features/provide_proxy_info/proxy_info.c Outdated
Comment thread src/features/sign_message/cmd_sign_message.c
Comment thread src/features/generic_tx_parser/tx_ctx.c
Comment thread src/features/generic_tx_parser/tx_ctx.c
Comment thread src/features/generic_tx_parser/tx_ctx.c
Comment thread src/features/sign_message_eip712/field_hash.c
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.02%. Comparing base (31bdcdc) to head (c8318ca).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #977   +/-   ##
========================================
  Coverage    55.02%   55.02%           
========================================
  Files           16       16           
  Lines         1592     1592           
  Branches       201      201           
========================================
  Hits           876      876           
- Misses         705      712    +7     
+ Partials        11        4    -7     
Flag Coverage Δ
unittests 55.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bboilot-ledger bboilot-ledger marked this pull request as ready for review April 3, 2026 08:27
@bboilot-ledger bboilot-ledger changed the base branch from master to develop April 3, 2026 08:29
@apaillier-ledger apaillier-ledger merged commit e03930b into develop Apr 7, 2026
225 checks passed
@apaillier-ledger apaillier-ledger deleted the security_review_1.22 branch April 7, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants