fix: Out-of-bounds read on zero-length int8 EIP-712 fields during display formatting#980
Merged
apaillier-ledger merged 1 commit intoApr 9, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #980 +/- ##
========================================
Coverage 55.02% 55.02%
========================================
Files 16 16
Lines 1592 1592
Branches 198 201 +3
========================================
Hits 876 876
- Misses 680 712 +32
+ Partials 36 4 -32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0104e66 to
f8420a9
Compare
apaillier-ledger
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Automated security fix for Out-of-bounds read on zero-length int8 EIP-712 fields during display formatting (High).
CWE: CWE-CWE-125
OWASP: A03:2021-Injection
Fix Confidence: high
What Changed
Added strict length validation for signed integer display formatting in ui_712_format_int(). Zero-length signed integers are now rejected before any formatting work, and the int8 branch now requires exactly one byte before dereferencing data[0], eliminating the out-of-bounds read.
Caveats
Verification Checklist
Created by Cerberus Merlin