fix: Blind-signing gate is bypassed for single-byte calldata 0x00 transactions#983
Merged
apaillier-ledger merged 1 commit intoApr 9, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #983 +/- ##
========================================
Coverage 55.02% 55.02%
========================================
Files 16 16
Lines 1592 1592
Branches 201 201
========================================
Hits 876 876
Misses 712 712
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
apaillier-ledger
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Automated security fix for Blind-signing gate is bypassed for single-byte calldata 0x00 transactions (High).
CWE: CWE-CWE-285
OWASP: A01:2021-Broken Access Control
Fix Confidence: high
What Changed
Removed the special-case in process_data() that treated a single-byte calldata payload of 0x00 as if no calldata were present. Non-empty calldata now preserves the dataPresent state set earlier by custom_processor(), so blind-signing checks still apply for 0x00 calldata while true zero-length data fields remain unaffected.
Verification Checklist
Created by Cerberus Merlin