feat : sign fullCommitment for zkApp#39
Merged
sportron-ledger merged 11 commits intoLedgerHQ:developfrom Apr 22, 2026
Merged
Conversation
Feat/sign zk field
* add loading screens to long computations * update tests * try.mjs scripts * snapshots
* change message to sign hash * bump version * snapshots * handle undeterministic processing snapshots
* feat: show processing screen during silent get_address * bump version * snapshots
* fix: prevent concurrent APDU processing during UI review Introduce a `review_pending` flag to block new commands while the device is waiting for user approval. This prevents the host from mutating state or buffers during an asynchronous review window, addressing potential race conditions on transports like BLE. * improvement: update zemu tests configuration and dependencies Update Jest configuration to handle ESM-only dependencies like `get-port` and bump multiple devDependencies (including Zemu, Ledgerhq, and ESLint plugins) to their latest versions. * test: update zemu snapshots Update the main menu UI snapshots for various device models (Nano S, Nano S+, Nano X, Stax, Flex) to reflect recent changes. * refactor: centralize review lock management in main dispatcher Move the `review_pending` flag logic from individual command handlers into the central APDU dispatcher. This ensures the lock is consistently acquired at the start of processing and automatically released upon any command completion (success or error) or transport reset, reducing the risk of the dispatcher becoming permanently locked.
* refactor: centralize blind signing logic and add safety checks - Move duplicated blind signing functions from UI-specific files into a shared `menu_common.c`. - Add NULL and length checks to `bytes_to_hex_display` to prevent potential crashes. * bump version
sportron-ledger
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
develop