-
Notifications
You must be signed in to change notification settings - Fork 0
Add BIP-85 applications to Flex and Stax #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #14 +/- ##
===========================================
+ Coverage 60.04% 60.98% +0.93%
===========================================
Files 14 18 +4
Lines 1632 1671 +39
Branches 266 270 +4
===========================================
+ Hits 980 1019 +39
Misses 612 612
Partials 40 40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b8567ad to
19e4db7
Compare
df7fbad to
1aa44be
Compare
7380f7c to
b59a828
Compare
|
Hi @lpascal-ledger, Just a gentle reminder that this PR is ready for review whenever your team gets a chance. Apart from bug fixes this version (v1.9,0) will probably not have any more updates with additional features and tools. For now the app is feature complete. |
|
Hey @aido 👋 Unfortunately it is not up to us to plan reviews on these kind of PR, but rather @vforgeoux-ledger. As your app is a bit special vs. others, I'm not sure how updates are managed, but FWIW most 3rd party developer need to go through the app submission form for that. |
As suggested, Ledger Device App update form completed and submitted. |
|
Hey @fbeutin-ledger, The Ledger Rule Enforcer checks seem to be failing with the same error for Stax and Flex: Is this an issue with the app or with the |
This PR adds the following BIP-85 applications for Flex and Stax devices:
The code has also been written for other BIP-85 applications such as hex output and dice throws but a UI has not yet been added for these while I decide if they will be useful or just add bloat to the app. They may appear in a future version.
I am also debating what BIP-85 applications (if any) should be added to Nano devices.
Note
The app support page at https://support.ledger.com/article/Seed-tool may have to be updated to include BIP85 if/when this PR is merged.
This PR is currently a work in progress while I add some function tests.