Skip to content

[NAPPS-1269] - add fa2 token support - #21

Merged
tdejoigny-ledger merged 38 commits into
LedgerHQ:developfrom
yldio:feat/add-fa2-token-support
Apr 15, 2026
Merged

[NAPPS-1269] - add fa2 token support#21
tdejoigny-ledger merged 38 commits into
LedgerHQ:developfrom
yldio:feat/add-fa2-token-support

Conversation

@pvoliveira

@pvoliveira pvoliveira commented Mar 18, 2026

Copy link
Copy Markdown

Checklist

  • App update process has been followed
  • Target branch is develop
  • Application version has been bumped

Description

  • Adds clear signing (no expert mode) to FA2 token transactions;
  • Fix make docker-images command;
  • Adds GOLDEN_RUN parameter to integration_tests_basic_% command;

NAPPS-1269

Comment thread app/src/parser/operation_parser.c Outdated
@pvoliveira
pvoliveira force-pushed the feat/add-fa2-token-support branch from a2dbcaa to f715d4b Compare March 20, 2026 12:03
@pvoliveira
pvoliveira force-pushed the feat/add-fa2-token-support branch from f715d4b to f93dd27 Compare March 23, 2026 10:37
@pvoliveira
pvoliveira force-pushed the feat/add-fa2-token-support branch from f93dd27 to 8e15e39 Compare March 23, 2026 12:41
@pvoliveira pvoliveira changed the title Feat/add fa2 token support NAPPS-1269 - add fa2 token support Mar 26, 2026
@pvoliveira pvoliveira changed the title NAPPS-1269 - add fa2 token support [NAPPS-1269] - add fa2 token support Mar 26, 2026
@pvoliveira
pvoliveira marked this pull request as ready for review March 31, 2026 09:37

@acewf acewf left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my knowledge to approve this is low. although approved better to someone else to check it

@dbaranov-hoodies dbaranov-hoodies left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good

Minor comments/improvement suggestions only.

Comment thread Makefile Outdated
Comment thread app/src/parser/operation_parser.c Outdated
Comment thread app/src/parser/operation_parser.c Outdated
Comment thread app/src/parser/operation_state.h Outdated
Comment thread app/src/parser/operation_parser.c Outdated
Comment thread docker/Dockerfile.ocaml Outdated
Comment thread tests/integration/app_vars.sh Outdated
Comment thread app/src/parser/operation_parser.c
Comment thread app/src/parser/operation_parser.c Outdated

@dbaranov-hoodies dbaranov-hoodies left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ! 🚀

@pvoliveira
pvoliveira force-pushed the feat/add-fa2-token-support branch 7 times, most recently from 0455ea6 to 453e723 Compare April 10, 2026 12:03
- remove dependency on pytezos (and Linux package libsodium)
- re-organize the ragger tests to be closer to the app-boilerplate app repo
- enable reusable Github workflows for app repositories
@pvoliveira
pvoliveira force-pushed the feat/add-fa2-token-support branch from 453e723 to 4d11e60 Compare April 10, 2026 12:18
@codecov-commenter

Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@pvoliveira
pvoliveira force-pushed the feat/add-fa2-token-support branch from f684064 to 7fe2aad Compare April 10, 2026 13:27
@pvoliveira
pvoliveira force-pushed the feat/add-fa2-token-support branch from 3d6fb91 to 0347a67 Compare April 10, 2026 15:13
@pvoliveira
pvoliveira force-pushed the feat/add-fa2-token-support branch from b08ec10 to 2c0014b Compare April 10, 2026 16:30
@pvoliveira
pvoliveira force-pushed the feat/add-fa2-token-support branch from 2c0014b to 787a452 Compare April 10, 2026 16:42

@dbaranov-hoodies dbaranov-hoodies left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ!

@tdejoigny-ledger
tdejoigny-ledger merged commit 8c5dbcf into LedgerHQ:develop Apr 15, 2026
187 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants