Fix issue when a LP have a .hex with several areas#150
Merged
dmorais-ledger merged 1 commit intodevelopfrom Jul 30, 2025
Merged
Fix issue when a LP have a .hex with several areas#150dmorais-ledger merged 1 commit intodevelopfrom
dmorais-ledger merged 1 commit intodevelopfrom
Conversation
tjoly-ledger
approved these changes
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the .hex file have several areas, the offset is reset to 0 without taking in account startAddress value.
(this occur for exemple when a language pack is > 64 Kb, but not only)
As Language pack APDUs are not secure ins, we can't use the selectSegment(startAddress) feature.
=> We need to take in account startAddress with offset to compute the real offset.