Skip to content

fix: prevent hasNetwork prop from being forwarded to DOM #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LucasWerey merged 2 commits into from
Nov 7, 2025
Merged

fix: prevent hasNetwork prop from being forwarded to DOM #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d7e36a
fix: prevent `hasNetwork` prop from being forwarded to DOM
meriadec Nov 7, 2025
6efdf65
chore: bump @ledgerhq/crypto-icons version to 1.2.1
meriadec Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@ledgerhq/crypto-icons",
"version": "1.2.0",
"version": "1.2.1",
"description": "Crypto icons by Ledger",
"license": "MIT",
"main": "dist/index.js",
Expand Down
8 changes: 4 additions & 4 deletions lib/src/components/CryptoIcon/CryptoIcon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@ import FallbackIcon from '../FallbackIcon/FallbackIcon';
import IconWrapper, { RoundedIcon, Skeleton } from '../IconWrapper/IconWrapper';
import { CryptoIconProps } from './CryptoIcon.types';

const Icon = styled(RoundedIcon)<{ hasNetwork: boolean }>`
const Icon = styled(RoundedIcon)<{ $hasNetwork: boolean }>`
height: 100%;
width: 100%;
${({ hasNetwork }) =>
hasNetwork
${({ $hasNetwork }) =>
$hasNetwork
? 'mask-image: radial-gradient(circle closest-side at 81.5% 81.5%, transparent 125%, white 130%);'
: ''}
`;
Expand All @@ -36,7 +36,7 @@ const CryptoIcon: FC<CryptoIconProps> = ({
return (
<IconWrapper size={size} theme={theme}>
{iconUrl ? (
<Icon theme={theme} src={iconUrl} alt={ticker} hasNetwork={!!networkUrl} />
<Icon theme={theme} src={iconUrl} alt={ticker} $hasNetwork={!!networkUrl} />
) : (
<FallbackIcon ticker={ticker} size={size} />
)}
Expand Down