chore: adapt CI for attested publish on npm#81
Open
xchalle wants to merge 14 commits into
Open
Conversation
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
Deploying crypto-icons-storybook-react-native with
|
| Latest commit: |
f823ca7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ffd9d230.crypto-icons-storybook-react-native.pages.dev |
| Branch Preview URL: | https://xchalle-release-workflows.crypto-icons-storybook-react-native.pages.dev |
Deploying crypto-icons with
|
| Latest commit: |
46efe3a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://152933e4.crypto-icons.pages.dev |
| Branch Preview URL: | https://xchalle-release-workflows.crypto-icons.pages.dev |
Deploying crypto-icons-storybook with
|
| Latest commit: |
46efe3a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://32e86d00.crypto-icons-storybook.pages.dev |
| Branch Preview URL: | https://xchalle-release-workflows.crypto-icons-storybook.pages.dev |
Update tarball naming convention to replace slashes with underscores in PR name.
Removed working-directory specification for npm config and publish steps.
Use xchalle/attest-action-package-manager-support branch for testing the updated attest-for-npmsjs-com action with pnpm support and hardened GITHUB_OUTPUT writes. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Comment out the step for publishing attested tarball to JFrog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the workflow files for publishing and releasing packages to improve consistency, directory structure, and attestation/signing steps. The main changes involve standardizing the use of the
distdirectory, updating attestation actions, and ensuring all relevant steps operate in the correct working directory.Workflow improvements and directory structure:
distdirectory (previously sometimeslib/dist), and ensured the directory is created before packing. (.github/workflows/publishBranch.yaml,.github/workflows/release.yaml) [1] [2]./distinstead of./lib/distfor improved consistency. (.github/workflows/publishBranch.yaml,.github/workflows/release.yaml) [1] [2]Attestation and publishing process:
.github/workflows/publishBranch.yaml,.github/workflows/release.yaml) [1] [2]./dist/directory for proper file access and environment consistency. (.github/workflows/publishBranch.yaml,.github/workflows/release.yaml) [1] [2] [3] [4]