✨ (solana-signer) [DSDK-1098]: Solana transaction check & Solana provide context refactor#1481
Merged
fAnselmi-Ledger merged 6 commits intoMay 13, 2026
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
Contributor
fAnselmi-Ledger
force-pushed
the
feat/dsdk-1098-solana-transaction-check
branch
from
8c10d42 to
68cc08f
Compare
fAnselmi-Ledger
force-pushed
the
feat/dsdk-1098-solana-transaction-check
branch
from
68cc08f to
106e209
Compare
fAnselmi-Ledger
force-pushed
the
feat/no-issue-improve-typing-into-context-module-refactor
branch
from
86de6a6 to
ebcbbeb
Compare
…xt-provider registry
fAnselmi-Ledger
force-pushed
the
feat/dsdk-1098-solana-transaction-check
branch
from
106e209 to
aaaa126
Compare
aussedatlo
reviewed
May 13, 2026
| resolver: ApplicationResolver, | ||
| ) { | ||
| this.modelId = deviceState.deviceModelId; | ||
| this.appName = |
Contributor
There was a problem hiding this comment.
[ASK] why appName can be undefined?
Contributor
Author
There was a problem hiding this comment.
ConnectedState variant has no currentApp, which is why the narrowing falls back to undefined
Contributor
There was a problem hiding this comment.
if the state is connected but not ready yet we should not enter in this part of code no? because we have the same problem with other signers, wdyt?
Contributor
Author
There was a problem hiding this comment.
Agree it's an issue across signers! Currently harmless here because SolanaApplicationResolver.resolve already returns isCompatible: false for Connected state, so the undefined fallback never affects the result.
fAnselmi-Ledger
force-pushed
the
feat/dsdk-1098-solana-transaction-check
branch
from
aaaa126 to
5da4263
Compare
aussedatlo
reviewed
May 13, 2026
| resolver: ApplicationResolver, | ||
| ) { | ||
| this.modelId = deviceState.deviceModelId; | ||
| this.appName = |
Contributor
There was a problem hiding this comment.
if the state is connected but not ready yet we should not enter in this part of code no? because we have the same problem with other signers, wdyt?
aussedatlo
reviewed
May 13, 2026
|
aussedatlo
approved these changes
May 13, 2026
fAnselmi-Ledger
merged commit 86d611e
into
feat/no-issue-improve-typing-into-context-module-refactor
30 of 32 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Adds end-to-end Solana transaction-check support, layered on top of the typing/multichain refactor in the base branch.
Solana app: APDU + opt-in flow
ProvideWeb3CheckCommand,Web3CheckOptInCommandGetAppConfigurationCommandextended to expose transaction-check opt-in/enabled fieldsSignTransactionDeviceActionextended with the opt-in state-machine branch (gated by app version, device model, opt-in flag)Solana signer: provide-context refactor
ProvideTransactionContextTasksplit into a per-type context-provider registry (provideContextRegistry.tsdispatching toprovideTokenContext,provideLifiContext,provideTransactionCheckContext)SolanaContextSuccessTypewithout a registry handler is now a compile errorContext module: Solana transaction-check loader
SOLANA_TRANSACTION_CHECKclear-sign context type with typed payload{ descriptor: string }SolanaTransactionCheckLoader(modules/multichain/transaction-check/loaders/) sharing the existingHttpTransactionCheckDataSourcewith the Ethereum loader, hits/solana/scan/txsolanaTransactionCheckModuleFactorywired into the Solanacaseofdi.tsandDefaultContextModuleSolanaTransactionScanChainIdenum (Mainnet/Devnet/Testnet) exposed frommodules/solana/model/Solana signer: wire transaction-check
BuildTransactionContextTaskrequestsSOLANA_TRANSACTION_CHECKalongsideSOLANA_TOKEN/SOLANA_LIFI/SOLANA_TRUSTED_NAMEand includes the result inloadersResultssignerAddress+ bs58-encodedtransactionBytes+SolanaTransactionScanChainId.MAINNETprovideTransactionCheckContexthandler: loads the PKI cert then chunks the descriptor viaProvideWeb3CheckCommand❓ Context
✅ Checklist
Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.
🧐 Checklist for the PR Reviewers