🐛 (clear-signing-tester) [NO-ISSUE]: Use previous Speculos Docker image#1496
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Contributor
There was a problem hiding this comment.
Pull request overview
Reverts the cs-tester Speculos controller to use the ghcr.io/ledgerhq/speculos Docker image, realigning it with the CI workflow which still pulls that image. Command-line arguments are updated to match this image's native speculos entrypoint.
Changes:
- Restore
SPECULOS_DOCKER_IMAGE_BASEtoghcr.io/ledgerhq/speculos. - Rebuild docker command with
--model(mappingnanos+→nanosp), drop--user, moveappPath/plugin args after flags. - Update README
docker pullinstruction to match.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/clear-signing-tester/src/infrastructure/service-controllers/SpeculosServiceController.ts | Switch image base and rebuild command args for the speculos entrypoint. |
| apps/clear-signing-tester/README.md | Update docker pull command to the speculos image. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aussedatlo
force-pushed
the
fix/no-issue-update-speculos-image
branch
from
6d7e73a to
61ba596
Compare
Restore ghcr.io/ledgerhq/speculos as the Docker image and adapt the command to its native speculos entrypoint, so the controller is aligned with the CI workflow which still pulls that image. The device model is inferred from the .elf file, so no --model argument is passed. Co-authored-by: Cursor <cursoragent@cursor.com>
aussedatlo
force-pushed
the
fix/no-issue-update-speculos-image
branch
from
61ba596 to
c808a03
Compare
|
mbertin-ledger
approved these changes
May 18, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Restore
ghcr.io/ledgerhq/speculosas the Speculos Docker image used by the clear-signing-tester (cs-tester) controller, and revert the command-line arguments to match that image's nativespeculosentrypoint (--model nanosp/...,appPath/plugins appended after the flags, no--userflag).Why: the CI workflow in
.github/actions/cs-tester-composite/action.ymlstill pullsghcr.io/ledgerhq/speculos, while the controller had been pointed atghcr.io/ledgerhq/ledger-app-builder/ledger-app-dev-tools. The two were out of sync, which broke local/CI runs. This change reuses the previous Speculos image (see commit7ff5f9844for the original setup) so the controller, the README, and the CI action all reference the same image again.Behavior is otherwise unchanged (image pull / stale checks, CAL
-pflag, volumes, ports, container naming, custom-app and plugin handling,start/stoplifecycle are all preserved).❓ Context
JIRA or GitHub link: NO-ISSUE
Feature: cs-tester / Speculos Docker image alignment
✅ Checklist
Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.
apps/clear-signing-testerapp, not a published package.apps/clear-signing-tester/README.mdupdated to referenceghcr.io/ledgerhq/speculos:latest.apps/clear-signing-tester/src/infrastructure/service-controllers/SpeculosServiceController.ts: image base reverted toghcr.io/ledgerhq/speculos; command rebuilt with--model(mappingnanos+→nanosp),appPath/plugins after the flags, and--userremoved.apps/clear-signing-tester/README.md:docker pullinstruction updated.🧐 Checklist for the PR Reviewers
Made with Cursor