Skip to content

✨ (device-management-kit) [NO-ISSUE]: Detect onboarded device from GetOsVersion #1521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
pdeville-ledger wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

✨ (device-management-kit) [NO-ISSUE]: Detect onboarded device from GetOsVersion #1521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/onboarded-status-from-os-version.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@ledgerhq/device-management-kit": minor
---

Detect onboarded device status from `GetOsVersionCommand` (`secureElementFlags.isOnboarded`) in `GetDeviceStatusDeviceAction`. The action now returns `Left(DeviceNotOnboardedError)` for unseeded devices instead of a stubbed `true`. `OpenAppDeviceAction` no longer runs a separate stubbed onboarding check and inherits the real one from its child machine. On success in a ready state, `firmwareVersion` (with `metadata`) and `isSecureConnectionAllowed` are persisted in the session state so consumers can read onboarding without an extra command.
1 change: 1 addition & 0 deletions packages/device-management-kit/src/api/command/os/__mocks__/GetOsVersionCommand.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ export const getOsVersionCommandResponseMockBuilder = (
isMcuCodeSigned: true,
isInRecoveryMode: false,
},
...props,
},
[DeviceModelId.STAX]: {
isBootloader: false,
Expand Down
Loading
Loading