Skip to content
This repository was archived by the owner on Jul 15, 2022. It is now read-only.

Origin Dollar (OUSD) Icon#1601

Open
micahalcorn wants to merge 2 commits intoLedgerHQ:masterfrom
OriginProtocol:master
Open

Origin Dollar (OUSD) Icon#1601
micahalcorn wants to merge 2 commits intoLedgerHQ:masterfrom
OriginProtocol:master

Conversation

@micahalcorn
Copy link

Context (issues, jira)

Accompanying discussion: LedgerHQ/ledger-live-desktop#4555

Description / Usage

This adds the SVG icon for Origin Dollar (OUSD). It can also be pulled from https://ousd.com/images/ousd-token-icon.svg anytime.

Expectations

  • Test coverage: The changes of this PR are covered by test. Unit test were added with mocks when depending on a backend/device.
  • No impact: The changes of this PR have ZERO impact on the userland. Meaning, we can use these changes without modifying LLD/LLM at all. It will be a "noop" and the maintainers will be able to bump it without changing anything.

@micahalcorn micahalcorn requested a review from a team January 1, 2022 23:07
@vercel
Copy link

vercel bot commented Jan 1, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ledgerhq/ledger-live-common/GtMwu1YPKsQ6Nn9LkJ4Mji5FMpBF
✅ Preview: https://ledger-live-common-git-fork-originprotocol-master-ledgerhq.vercel.app

.st2{fill:#FAFBFC;}
.st3{fill:url(#SVGID_1_);}
.st4{fill:url(#SVGID_2_);}
</style>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can't afford to have id=, class= or <style> in these SVG because we will convert them back into react class. Thanks

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gre have changed the icon to not include id, class or <style> tags

@gre gre added the coin-icon label Jan 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants