Skip to content
This repository was archived by the owner on Jul 15, 2022. It is now read-only.

Timestamp scroll for elrond transactions#1703

Open
AlexandruPislariu wants to merge 4 commits intoLedgerHQ:masterfrom
multiversx:master
Open

Timestamp scroll for elrond transactions#1703
AlexandruPislariu wants to merge 4 commits intoLedgerHQ:masterfrom
multiversx:master

Conversation

@AlexandruPislariu
Copy link
Contributor

Context (issues, jira)

Description / Usage

Expectations

  • Test coverage: The changes of this PR are covered by test. Unit test were added with mocks when depending on a backend/device.
  • No impact: The changes of this PR have ZERO impact on the userland. Meaning, we can use these changes without modifying LLD/LLM at all. It will be a "noop" and the maintainers will be able to bump it without changing anything.

@AlexandruPislariu AlexandruPislariu requested a review from a team February 14, 2022 14:21
@vercel
Copy link

vercel bot commented Feb 14, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ledgerhq/ledger-live-common/A1fL32Yc34pXNqAZ5w3zMuYEDaHw
✅ Preview: https://ledger-live-common-git-fork-elrondnetwork-master-ledgerhq.vercel.app

@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #1703 (b2f61cc) into master (92de099) will increase coverage by 0.97%.
The diff coverage is 0.00%.

❗ Current head b2f61cc differs from pull request most recent head d7865dd. Consider uploading reports for the commit d7865dd to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1703      +/-   ##
==========================================
+ Coverage   53.81%   54.79%   +0.97%     
==========================================
  Files         516      582      +66     
  Lines       22217    22770     +553     
  Branches     5322     5663     +341     
==========================================
+ Hits        11956    12476     +520     
- Misses      10188    10245      +57     
+ Partials       73       49      -24     
Impacted Files Coverage Δ
src/families/elrond/api/apiCalls.ts 13.51% <0.00%> (-69.35%) ⬇️
src/families/elrond/js-synchronisation.ts 36.84% <0.00%> (-63.16%) ⬇️
src/libcore/createAccountFromDevice.ts 8.82% <0.00%> (-91.18%) ⬇️
src/families/cosmos/libcore-mergeOperations.ts 13.04% <0.00%> (-78.27%) ⬇️
src/families/celo/hw-app-celo.ts 3.38% <0.00%> (-77.97%) ⬇️
src/families/bitcoin/networks.ts 5.88% <0.00%> (-76.48%) ⬇️
src/libcore/buildAccount/index.ts 14.43% <0.00%> (-76.29%) ⬇️
src/families/bitcoin/js-signOperation.ts 20.89% <0.00%> (-76.12%) ⬇️
src/families/crypto_org/api/sdk.ts 16.85% <0.00%> (-75.29%) ⬇️
src/families/celo/js-getFeesForTransaction.ts 26.66% <0.00%> (-73.34%) ⬇️
... and 389 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91f92bb...d7865dd. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants