This repository was archived by the owner on Jul 15, 2022. It is now read-only.
[FEATURE] Add FTX to live swap#1927
Closed
chabroA wants to merge 24 commits into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chabroA
force-pushed
the
feat/add-ftx-to-swap
branch
from
cc71ba2 to
067ce8e
Compare
To set the mockCheckQuote response with an env var
using staging API url for build
to reflect api return values (codeName instead of code)
chabroA
force-pushed
the
feat/add-ftx-to-swap
branch
from
067ce8e to
fcc6d23
Compare
7 tasks
revert initSwapErrorResult to initSwapError and add swapId as optional state variable To avoid breaking changes
Codecov Report
@@ Coverage Diff @@
## develop #1927 +/- ##
===========================================
+ Coverage 58.59% 59.20% +0.60%
===========================================
Files 450 512 +62
Lines 20541 21253 +712
Branches 5273 5733 +460
===========================================
+ Hits 12036 12582 +546
- Misses 8476 8649 +173
+ Partials 29 22 -7
Continue to review full report at Codecov.
|
to locally test widgets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context (issues, jira)
Description / Usage
🔗 LedgerHQ/ledger-live-desktop#4959
Add FTX and FTX.US as swap provider with all associated logic
Expectations