Skip to content
This repository was archived by the owner on Jun 16, 2022. It is now read-only.

Misc/local ftx build#4977

Closed
chabroA wants to merge 74 commits into
developfrom
misc/local-ftx-build
Closed

Misc/local ftx build#4977
chabroA wants to merge 74 commits into
developfrom
misc/local-ftx-build

Conversation

@chabroA

@chabroA chabroA commented May 12, 2022

Copy link
Copy Markdown
Contributor

🦒 Context (issues, jira)

💻 Description / Demo (image or video)

🖤 Expectations to reach

PR must pass CI, rebase develop if conflicts. Thanks!

  • on QA: at least one of these two checkboxes must be checked:
    • a specific test planned is defined on Jira
    • this PR is covered by automatic UI test
  • on delivery: at least one of these two checkboxes must be checked:
    • Option 1: no impact: The changes of this PR have ZERO impact on the userland (invisible for users)
    • Option 2: atomic delivery: the changes is atomic and complete (no partial delivery)

@chabroA chabroA requested a review from a team May 12, 2022 15:02
@chabroA chabroA requested a review from a team as a code owner May 12, 2022 15:02
@chabroA chabroA changed the base branch from feat/add-ftx-to-swap to develop May 12, 2022 15:03
@chabroA chabroA requested review from a team as code owners May 12, 2022 15:03
@chabroA chabroA requested review from a team May 12, 2022 15:03
@github-actions

Copy link
Copy Markdown

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements 8.74% 9/103
🔴 Branches 0% 0/19
🔴 Functions 2.94% 1/34
🔴 Lines 8.33% 8/96

Test suite run success

1 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from 5b7552b

@chabroA chabroA added HODL for PRs: this is blocked, we can't merge yet internal discussion we are discussing this new feature internally. HODL until there is a decision. labels May 12, 2022
@chabroA

chabroA commented May 16, 2022

Copy link
Copy Markdown
Contributor Author

Close because not relevant anymore and duplicate of #4959

@chabroA chabroA closed this May 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

HODL for PRs: this is blocked, we can't merge yet internal discussion we are discussing this new feature internally. HODL until there is a decision.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants