This repository was archived by the owner on Jun 16, 2022. It is now read-only.
LIVE-2003 - Feature - Pass urls through regex to replace template by locale#2451
Open
nparigi-ledger wants to merge 1 commit intodevelopfrom
Open
Conversation
|
Thanks for your contribution.
Why /generate-screenshots ?If your PR contains UI related changes, |
Closed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Substitute url strings by getter function with regex replacing template {locale} by current locale
Ex: ledger.com/{locale}/ become ledger.com/fr/
Type
Feature
Context
https://ledgerhq.atlassian.net/jira/software/c/projects/LIVE/boards/463?modal=detail&selectedIssue=LIVE-2003&sprint=994&assignee=6102d4f20b454a0068cad0d6
Parts of the app affected / Test plan
Config urls