Skip to content

crypto-icons bump and LLM CurrencyIcon simplification#13135

Merged
gre-ledger merged 1 commit into
developfrom
fix/crypto-icons-llm-memo-issue
Dec 5, 2025
Merged

crypto-icons bump and LLM CurrencyIcon simplification#13135
gre-ledger merged 1 commit into
developfrom
fix/crypto-icons-llm-memo-issue

Conversation

@gre-ledger

@gre-ledger gre-ledger commented Dec 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

crypto-icons bump :

Like in #13085 we can simplify the CryptoIcon component : the circle is already the default behavior, internal to the underlying component of crypto-icons lib. therefore we can remove this prop (as well as bg)

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@gre-ledger gre-ledger requested a review from a team as a code owner December 4, 2025 13:23
@gre-ledger gre-ledger requested a review from a team December 4, 2025 13:23
@vercel

vercel Bot commented Dec 4, 2025 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
native-ui-storybook Ready Ready Preview Comment Dec 4, 2025 5:06pm
react-ui-storybook Ready Ready Preview Comment Dec 4, 2025 5:06pm
web-tools Error Error Dec 4, 2025 5:06pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
ledger-live-github-bot Ignored Ignored Preview Dec 4, 2025 5:06pm

@live-github-bot live-github-bot Bot added the mobile Has changes in LLM label Dec 4, 2025
@github-actions

github-actions Bot commented Dec 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

⚠️ E2E tests are required

Changes detected require e2e testing before merge (even before asking for any review).

🖥️ Desktop

-> Run Desktop E2E

  • Select "Run workflow"
  • Branch: fix/crypto-icons-llm-memo-issue
  • Device: nanoSP or stax

📱 Mobile

-> Run Mobile E2E

  • Select "Run workflow"
  • Branch: fix/crypto-icons-llm-memo-issue
  • Device: nanoX

@gre-ledger gre-ledger force-pushed the fix/crypto-icons-llm-memo-issue branch from 5aeaad0 to acb91bc Compare December 4, 2025 16:35
@live-github-bot live-github-bot Bot added the ui Has changes in the design system library label Dec 4, 2025
@gre-ledger gre-ledger changed the title fix(llm): CurrencyIcon simplification crypto-icons bump and LLM CurrencyIcon simplification Dec 4, 2025
@gre-ledger gre-ledger force-pushed the fix/crypto-icons-llm-memo-issue branch from acb91bc to 3eef0a5 Compare December 4, 2025 17:04
@sonarqubecloud

sonarqubecloud Bot commented Dec 4, 2025

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
6.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@gre-ledger gre-ledger merged commit 75afa17 into develop Dec 5, 2025
73 of 78 checks passed
@gre-ledger gre-ledger deleted the fix/crypto-icons-llm-memo-issue branch December 5, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ysitbon ysitbon ysitbon approved these changes
@tonykhaov tonykhaov tonykhaov approved these changes
@francois-guerin-ledger francois-guerin-ledger francois-guerin-ledger approved these changes
@mcayuelas-ledger mcayuelas-ledger mcayuelas-ledger left review comments

Assignees

@gre-ledger gre-ledger

Labels

mobile Has changes in LLM ui Has changes in the design system library

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gre-ledger @ysitbon @tonykhaov @mcayuelas-ledger @francois-guerin-ledger