Skip to content

fix(e2e): add missing testId#14709

Merged
LucasWerey merged 1 commit intodevelopfrom
fix/mad-test-id
Feb 23, 2026
Merged

fix(e2e): add missing testId#14709
LucasWerey merged 1 commit intodevelopfrom
fix/mad-test-id

Conversation

@LucasWerey
Copy link
Member

@LucasWerey LucasWerey commented Feb 23, 2026

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

image

RUN: https://github.com/LedgerHQ/ledger-live/actions/runs/22316821502

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@LucasWerey LucasWerey requested a review from a team as a code owner February 23, 2026 17:11
Copilot AI review requested due to automatic review settings February 23, 2026 17:11
@LucasWerey LucasWerey requested a review from a team as a code owner February 23, 2026 17:11
@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Feb 23, 2026
@github-actions
Copy link
Contributor

⚠️ E2E tests are required

Changes detected require e2e testing before merge (even before asking for any review).

🖥️ Desktop

-> Run Desktop E2E

  • Select "Run workflow"
  • Branch: fix/mad-test-id
  • Device: nanoSP or stax

📱 Mobile

-> Run Mobile E2E

  • Select "Run workflow"
  • Branch: fix/mad-test-id
  • Device: nanoX

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a missing testID to the Modular Drawer Asset Selection header when rendered with the Lumen bottom sheet, to support Detox/E2E element selection.

Changes:

  • Add testID="modular-drawer-Asset-title" to the BottomSheetHeader in the Lumen bottom sheet path for Asset Selection.

@sonarqubecloud
Copy link

@LucasWerey LucasWerey merged commit ab2357f into develop Feb 23, 2026
146 of 149 checks passed
@LucasWerey LucasWerey deleted the fix/mad-test-id branch February 23, 2026 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mobile Has changes in LLM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants