test(mobile): add E2E tests for main navigation (Wallet 4.0 & legacy) by deepyjr · Pull Request #14749 · LedgerHQ/ledger-live

deepyjr · 2026-02-24T14:10:25Z

✅ Checklist

npx changeset was attached.
Covered by automatic tests. E2E tests are included but W40 specs are currently blocked by a DetoxSync/BlurView native crash on iOS (NSNull __detox_sync_untrackAnimation). A follow-up fix is needed to patch DetoxSync or disable BlurView in test builds.
Impact of the changes:
- Main navigation tab bar elements (Wallet 4.0)
- Earn screen root view testability
- No runtime behavior change — only testID props and E2E test files added

📝 Description

Problem: The main navigation (TabBar) for Wallet 4.0 modes had no E2E test coverage. Navigation elements lacked testID props, making them untestable with Detox.

Solution:

Added testID props to LegacyTabNavigator tabs (tab-bar-portfolio, tab-bar-discover) and Earn screen root views (earn-screen)
Created MainNavigationPage page object with selectors for both W40 (bottom tabs, top bar) and legacy navigation elements
Added two spec files:
- mainNavigationWallet40.spec.ts — 7 tests covering W40 bottom tab navigation (Swap, Earn, Card, Home) and top bar navigation (My Ledger, Settings)
- mainNavigationLegacy.spec.ts — 5 tests covering legacy tab navigation (Earn, Discover, My Ledger, Portfolio)
Each test verifies both navigation to the correct destination page and visibility of navigation elements

Known blocker: W40 specs crash on iOS due to Lumen's TabBar using BlurView, which is incompatible with DetoxSync's animation tracking (-[NSNull __detox_sync_untrackAnimation]). A runtime Objective-C patch or DetoxSync fix is needed before W40 specs can run.

❓ Context

JIRA or GitHub link: LIVE-24697

🧐 Checklist for the PR Reviewers

The code aligns with the requirements described in the linked JIRA or GitHub issue.
The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
There are no undocumented trade-offs, technical debt, or maintainability issues.
The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
Any new dependencies have been justified and documented.
Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copilot

Pull request overview

This PR adds comprehensive E2E test coverage for the main navigation in both Wallet 4.0 and legacy modes. It introduces testIDs to navigation elements, creates a page object pattern, and implements a BlurView mock to work around a DetoxSync crash on iOS. The PR acknowledges a known blocker: W40 specs crash on iOS due to BlurView/DetoxSync incompatibility, but legacy specs should pass.

Changes:

Added E2E test infrastructure with two spec files covering W40 bottom/top navigation (7 tests) and legacy tab navigation (5 tests)
Added testID props to MainTabBar (W40), LegacyTabNavigator, and Earn screens for test element identification
Implemented BlurView mock via rspack alias to prevent DetoxSync crashes during E2E builds

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
e2e/mobile/specs/mainNavigationWallet40.spec.ts	New E2E tests for Wallet 4.0 navigation (bottom tabs and top bar)
e2e/mobile/specs/mainNavigationLegacy.spec.ts	New E2E tests for legacy navigation (bottom tabs)
e2e/mobile/page/wallet/mainNavigation.page.ts	New page object with selectors and methods for both W40 and legacy navigation
e2e/mobile/page/index.ts	Registered new MainNavigationPage in Application class
apps/ledger-live-mobile/src/screens/PTX/Earn/index.tsx	Added testID "earn-screen" to root View for test visibility verification
apps/ledger-live-mobile/src/screens/PTX/Earn/EarnV2Webview/index.tsx	Added testID "earn-screen" to root View (V2 implementation)
apps/ledger-live-mobile/src/mvvm/components/MainTabBar/useMainTabBarViewModel.ts	Added TAB_TEST_IDS mapping for W40 tabs (w40-tab-home, swap, earn, card)
apps/ledger-live-mobile/src/mvvm/components/MainTabBar/types.ts	Extended TabItemConfig type to include testID property
apps/ledger-live-mobile/src/mvvm/components/MainTabBar/MainTabBarView.tsx	Added testID="w40-tab-bar" to container and passed testID to TabBarItem
apps/ledger-live-mobile/src/components/RootNavigator/MainNavigator/LegacyTabNavigator.tsx	Added tabBarButtonTestID to Portfolio and Discover tabs
apps/ledger-live-mobile/rspack.config.mjs	Added Detox build detection and BlurView mock alias configuration
apps/ledger-live-mobile/e2e/mocks/react-native-blur.js	New BlurView mock to prevent DetoxSync animation tracking crashes
.changeset/add-e2e-main-navigation-tests.md	Documented test infrastructure addition as minor version change

e2e/mobile/page/wallet/mainNavigation.page.ts

github-actions · 2026-02-27T08:48:41Z

⚠️ E2E tests are required

Changes detected require e2e testing before merge (even before asking for any review).

📱 Mobile

-> Run Mobile E2E

Select "Run workflow"
Branch: feat/e2e-nav-bar
Device: nanoX

LucasWerey · 2026-02-27T08:58:45Z

e2e/mobile/specs/mainNavigationLegacy.spec.ts

Do we need to test it?

The task asks us to test the deactivation, so I thought we might as well include a test to check for any deviant behaviour.

Oups my bad I haven't updated the task but no need, it was in case we provided the user to have a toggle

LucasWerey · 2026-02-27T08:59:30Z

apps/ledger-live-mobile/src/mvvm/components/MainTabBar/useMainTabBarViewModel.ts

  [NavigatorName.CardTab]: { icon: CreditCard, activeIcon: CreditCardFill },
 };
+
+const TAB_TEST_IDS: Partial<Record<string, string>> = {


I think you can use it for some test id declaration accross the PR

Ok i will update

Copilot

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.

e2e/mobile/specs/mainNavigationWallet40.spec.ts

e2e/mobile/specs/mainNavigationLegacy.spec.ts

cunhabruno · 2026-02-27T13:37:53Z

e2e/mobile/page/wallet/mainNavigation.page.ts

+
+  @Step("Wait for Wallet 4.0 navigation to be ready")
+  async waitForWallet40Ready() {
+    await waitForElementById(this.topBarSettingsId, 120000);


Why 120000 here? I would keep the default one

cunhabruno · 2026-02-27T13:42:18Z

e2e/mobile/page/wallet/mainNavigation.page.ts

+    try {
+      await waitForElementById(this.portfolioAccountsListId, 5000);
+    } catch {
+      await waitForElementById(this.portfolioEmptyListId, 5000);


Ideally tests should not have unpredictable elements, it should be controlled in the flow if it should show assets or not.

cunhabruno · 2026-02-27T14:05:20Z

e2e/mobile/page/wallet/mainNavigation.page.ts

+  wallet40HomeTab = () => element(by.id("w40-tab-home"));
+  wallet40SwapTab = () => element(by.id("w40-tab-swap"));
+  wallet40EarnTab = () => element(by.id("w40-tab-earn"));
+  wallet40CardTab = () => element(by.id("w40-tab-card"));


Maybe you could simplify doing something dynamic like:
wallet40Tab = (tabName: TabName) => { return element(by.id(w40-tab-${tabName})); };

Copilot

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.

apps/ledger-live-mobile/src/components/RootNavigator/MainNavigator/LegacyTabNavigator.tsx

.changeset/add-e2e-main-navigation-tests.md

apps/ledger-live-mobile/e2e/mocks/react-native-blur.js

Add testID props to LegacyTabNavigator tabs (portfolio, discover) and Earn screen root views to enable element identification in Detox tests. LIVE-24697

Add MainNavigationPage with selectors for both Wallet 4.0 and legacy navigation elements. Add spec files for W40 and legacy navigation flows covering tab switching and destination page verification. Note: W40 specs are blocked by a DetoxSync/BlurView crash on iOS (NSNull __detox_sync_untrackAnimation) and require a fix before running. LIVE-24697 chore(mobile): add changeset for e2e main navigation tests LIVE-24697

…o screen identification

Copilot

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.

e2e/mobile/specs/mainNavigationWallet40.spec.ts

apps/ledger-live-mobile/rspack.config.mjs

e2e/mobile/specs/mainNavigationWallet40.spec.ts

sonarqubecloud · 2026-03-02T14:52:51Z

Quality Gate failed

Failed conditions
33.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

github-actions bot assigned deepyjr Feb 24, 2026

live-github-bot bot added the mobile Has changes in LLM label Feb 24, 2026

deepyjr force-pushed the feat/e2e-nav-bar branch 7 times, most recently from f2062b2 to 7379137 Compare February 27, 2026 08:04

deepyjr marked this pull request as ready for review February 27, 2026 08:04

deepyjr requested a review from a team as a code owner February 27, 2026 08:04

Copilot AI review requested due to automatic review settings February 27, 2026 08:04

deepyjr requested review from a team as code owners February 27, 2026 08:04

Copilot started reviewing on behalf of deepyjr February 27, 2026 08:05 View session

Copilot AI reviewed Feb 27, 2026

View reviewed changes

e2e/mobile/page/wallet/mainNavigation.page.ts Outdated Show resolved Hide resolved

e2e/mobile/page/wallet/mainNavigation.page.ts Show resolved Hide resolved

e2e/mobile/page/wallet/mainNavigation.page.ts Outdated Show resolved Hide resolved

deepyjr force-pushed the feat/e2e-nav-bar branch from 7379137 to 9e00e2c Compare February 27, 2026 08:45

deepyjr requested a review from a team as a code owner February 27, 2026 08:45

gre-ledger previously approved these changes Feb 27, 2026

View reviewed changes

LucasWerey reviewed Feb 27, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings February 27, 2026 09:04

deepyjr dismissed gre-ledger’s stale review via 5de6c59 February 27, 2026 09:04

deepyjr force-pushed the feat/e2e-nav-bar branch from 9e00e2c to 5de6c59 Compare February 27, 2026 09:04

Copilot started reviewing on behalf of deepyjr February 27, 2026 09:05 View session

Copilot AI reviewed Feb 27, 2026

View reviewed changes

e2e/mobile/specs/mainNavigationWallet40.spec.ts Outdated Show resolved Hide resolved

e2e/mobile/specs/mainNavigationLegacy.spec.ts Outdated Show resolved Hide resolved

deepyjr force-pushed the feat/e2e-nav-bar branch from 5de6c59 to 41f1192 Compare February 27, 2026 14:03

cunhabruno requested changes Feb 27, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings February 27, 2026 14:30

Copilot started reviewing on behalf of deepyjr February 27, 2026 14:31 View session

Copilot AI reviewed Feb 27, 2026

View reviewed changes

apps/ledger-live-mobile/src/components/RootNavigator/MainNavigator/LegacyTabNavigator.tsx Show resolved Hide resolved

.changeset/add-e2e-main-navigation-tests.md Show resolved Hide resolved

apps/ledger-live-mobile/e2e/mocks/react-native-blur.js Show resolved Hide resolved

deepyjr added 3 commits March 2, 2026 11:14

test(mobile): add testIDs for main navigation e2e testing

e0853aa

Add testID props to LegacyTabNavigator tabs (portfolio, discover) and Earn screen root views to enable element identification in Detox tests. LIVE-24697

refactor(mobile): unify tab navigation selectors and enhance portfoli…

10cc40f

…o screen identification

deepyjr force-pushed the feat/e2e-nav-bar branch from 0a69eae to 5257905 Compare March 2, 2026 11:24

fix(tests): merge the 2 tests inside one

07c9edd

Copilot AI review requested due to automatic review settings March 2, 2026 14:36

deepyjr force-pushed the feat/e2e-nav-bar branch from 5257905 to 07c9edd Compare March 2, 2026 14:36

Copilot started reviewing on behalf of deepyjr March 2, 2026 14:37 View session

Copilot AI reviewed Mar 2, 2026

View reviewed changes

e2e/mobile/specs/mainNavigationWallet40.spec.ts Show resolved Hide resolved

apps/ledger-live-mobile/rspack.config.mjs Show resolved Hide resolved

e2e/mobile/specs/mainNavigationWallet40.spec.ts Show resolved Hide resolved

Conversation

deepyjr commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Checklist

📝 Description

❓ Context

🧐 Checklist for the PR Reviewers

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ E2E tests are required

📱 Mobile

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Mar 2, 2026

Quality Gate failed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

deepyjr commented Feb 24, 2026 •

edited

Loading

github-actions bot commented Feb 27, 2026 •

edited

Loading