Skip to content

feat: adding adi currency support#14805

Merged
scavassa-yld merged 2 commits intodevelopfrom
feat/live-26844-adi-currency
Feb 26, 2026
Merged

feat: adding adi currency support#14805
scavassa-yld merged 2 commits intodevelopfrom
feat/live-26844-adi-currency

Conversation

@scavassa-yld
Copy link
Contributor

@scavassa-yld scavassa-yld commented Feb 25, 2026

✅ Checklist

📝 Description

Adding ADI currency

https://github.com/LedgerHQ/ledger-live/wiki/LLC:currency

Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bug fixes, you can explain the previous behaviour and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copilot AI review requested due to automatic review settings February 25, 2026 17:09
@scavassa-yld scavassa-yld requested review from a team as code owners February 25, 2026 17:09
@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs cli coin-modules labels Feb 25, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2026

⚠️ E2E tests are required

Changes detected require e2e testing before merge (even before asking for any review).

🖥️ Desktop

-> Run Desktop E2E

  • Select "Run workflow"
  • Branch: feat/live-26844-adi-currency
  • Device: nanoSP or stax

📱 Mobile

-> Run Mobile E2E

  • Select "Run workflow"
  • Branch: feat/live-26844-adi-currency
  • Device: nanoX

Affected coins modules: evm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for the ADI (Adi Foundation) cryptocurrency to Ledger Live. ADI is an EVM-based blockchain with chainId 36900 that uses Ethereum's Ledger app and supports ERC20 tokens. The implementation follows the standard pattern for adding new EVM currencies, including feature flag configuration, RPC/explorer setup, and test coverage.

Changes:

  • Added ADI currency definition with EVM family configuration (chainId 36900, Blockscout explorer)
  • Added feature flag currencyAdi to control currency availability
  • Updated all supported currency lists across desktop, mobile, CLI, and web-tools applications
  • Generated test snapshots for currency formatting and fee calculations

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
libs/ledgerjs/packages/cryptoassets/src/currencies.ts Added ADI currency definition with EVM configuration, explorer URLs, and metadata
libs/ledgerjs/packages/cryptoassets/src/abandonseed.ts Added EVM dead address for ADI abandon seed
libs/ledgerjs/packages/types-live/src/feature.ts Added currencyAdi feature flag type
libs/ledger-live-common/src/featureFlags/defaultFeatures.ts Registered ADI feature flag with default settings
libs/ledger-live-common/src/modularDrawer/hooks/useCurrenciesUnderFeatureFlag.ts Added ADI to feature-flagged currencies hook
libs/ledger-live-common/src/families/evm/config.ts Added EVM config for ADI (RPC node, Blockscout explorer, active status)
libs/coin-modules/coin-evm/src/specs.ts Set minimum balance for ADI to 0.001
apps/ledger-live-desktop/src/live-common-set-supported-currencies.ts Added ADI to desktop app supported currencies
apps/ledger-live-mobile/src/live-common-setup.ts Added ADI to mobile app supported currencies
apps/cli/src/live-common-setup-base.ts Added ADI to CLI supported currencies
apps/web-tools/src/live-common-setup.ts Added ADI to web-tools supported currencies
apps/ledger-live-desktop/tests/fixtures/wallet-api.ts Added ADI to wallet API test fixtures
apps/ledger-live-mobile/src/mvvm/features/Web3Hub/utils/api/mocks/manifests.ts Added ADI to Web3Hub mock manifests
libs/ledger-live-common/src/tests/test-helpers/environment.ts Added ADI to test environment
libs/ledger-live-common/src/tests/migration/account-migration.ts Added ADI to migration test currencies
libs/live-currency-format/src/snapshots/formatCurrencyUnit.test.ts.snap Generated snapshots for ADI currency formatting across locales
libs/coin-modules/coin-evm/src/editTransaction/snapshots/getFormattedFeeFields.test.ts.snap Generated snapshots for ADI fee field formatting
.changeset/shy-balloons-sniff.md Added changeset documenting ADI currency support

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 26, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
13 New Code Smells (required ≤ 1)
E Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@scavassa-yld scavassa-yld merged commit 8a7f3c7 into develop Feb 26, 2026
135 of 156 checks passed
@scavassa-yld scavassa-yld deleted the feat/live-26844-adi-currency branch February 26, 2026 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cli coin-modules common Has changes in live-common desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants