fix(xrp listoperations): 🐛 add fees operation for transactions th…#14881
fix(xrp listoperations): 🐛 add fees operation for transactions th…#14881
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the XRP listOperations logic to surface network fees for non-Payment transactions (e.g., unsupported token-related activity) by emitting FEES operations, and adds unit/integration coverage for the new behavior.
Changes:
- Extend XRP operation listing to include
FEESoperations for non-Paymenttransactions initiated by the queried address. - Add unit tests validating inclusion/exclusion of
FEESops and failed status handling. - Add API-level and mainnet integration tests plus a changeset for the package release.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| libs/coin-modules/coin-xrp/src/logic/listOperations.ts | Adds non-Payment transaction handling and converts them into FEES operations. |
| libs/coin-modules/coin-xrp/src/logic/listOperations.test.ts | Adds unit tests for FEES operation generation and filtering. |
| libs/coin-modules/coin-xrp/src/api/index.test.ts | Adds API wrapper tests ensuring FEES ops are returned/filtered correctly. |
| libs/coin-modules/coin-xrp/src/api/index.integ.test.ts | Adds a mainnet integration assertion for a FEES operation. |
| .changeset/flat-eagles-applaud.md | Declares a release bump for @ledgerhq/coin-xrp tied to the behavior change. |
| senders: [Account], | ||
| recipients: [], | ||
| details: { | ||
| xrpTxType: TransactionType, |
There was a problem hiding this comment.
question: do you think we can use ledgerOpType and give a type supported by the generic adapter (so it is ready if we support XRP token in Ledger Wallet one day), or is it too early ? regardless, I think it could be good to converge to a single key for sub operations
There was a problem hiding this comment.
I think it's a bit soon
Because right now FEES type is not only for token transafer but also for OFFER and all other type of transaction where the users paid fees !
But yes if we want to support Token we will have to rework Type on XRP
|
f9ac772 to
556714a
Compare
|



…at are not payment
✅ Checklist
npx changesetwas attached.📝 Description
Transaction is a token transaction, it’s expected we don’t get the full data if we don’t support tokens. However, the account has paid fees in this transaction so we added an operation of type FEES.
Screen.Recording.2026-02-27.at.12.35.30.mov
❓ Context
🧐 Checklist for the PR Reviewers