Skip to content

fix(e2e): wait for element before asserting in expectSwapLiveApp#14901

Merged
cunhabruno merged 1 commit intodevelopfrom
fix/swap-live-app-wait-before-assert
Mar 2, 2026
Merged

fix(e2e): wait for element before asserting in expectSwapLiveApp#14901
cunhabruno merged 1 commit intodevelopfrom
fix/swap-live-app-wait-before-assert

Conversation

@cunhabruno
Copy link
Contributor

@cunhabruno cunhabruno commented Mar 2, 2026

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

wait for element before asserting in expectSwapLiveApp

❓ Context

  • JIRA or GitHub link:
  • CI

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copilot AI review requested due to automatic review settings March 2, 2026 08:11
@cunhabruno cunhabruno requested a review from a team as a code owner March 2, 2026 08:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves reliability of the mobile e2e Swap Live App page-object by waiting for a key web element to be present before performing existence assertions, reducing test flakiness during webview load.

Changes:

  • Add an explicit waitWebElementByTestId call at the start of expectSwapLiveApp() before running toExist() assertions.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 2, 2026

@cunhabruno cunhabruno merged commit efcfc12 into develop Mar 2, 2026
69 of 75 checks passed
@cunhabruno cunhabruno deleted the fix/swap-live-app-wait-before-assert branch March 2, 2026 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants