Skip to content

feat(LIVE-27029): aleo operation details extra#14914

Merged
mdomanski-ext-ledger merged 1 commit intodevelopfrom
feat/aleo-operation-details-extra
Mar 3, 2026
Merged

feat(LIVE-27029): aleo operation details extra#14914
mdomanski-ext-ledger merged 1 commit intodevelopfrom
feat/aleo-operation-details-extra

Conversation

@mateuszpalosz-ext
Copy link
Contributor

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • custom renderer for account.extra for Aleo in operation details

📝 Description

Added custom renderer for account.extra in operation details drawer for Aleo. We want to expose only selected fields from the extra object.

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@live-github-bot live-github-bot bot added desktop Has changes in LLD translations Translation files have been touched coin-modules labels Mar 2, 2026
@mateuszpalosz-ext mateuszpalosz-ext force-pushed the feat/aleo-operation-details-extra branch from c12704b to 604b590 Compare March 2, 2026 13:21
@mateuszpalosz-ext mateuszpalosz-ext changed the title feat(LIVE-27029) aleo operation details extra feat(LIVE-27029): aleo operation details extra Mar 3, 2026
@mateuszpalosz-ext mateuszpalosz-ext force-pushed the feat/aleo-operation-details-extra branch from 604b590 to a850966 Compare March 3, 2026 13:52
@mateuszpalosz-ext mateuszpalosz-ext marked this pull request as ready for review March 3, 2026 13:52
@mateuszpalosz-ext mateuszpalosz-ext requested a review from a team as a code owner March 3, 2026 13:52
Copilot AI review requested due to automatic review settings March 3, 2026 13:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a family-specific renderer for Aleo operation.extra in the Operation Details drawer so only selected fields are displayed (starting with functionId), instead of showing all primitive fields from the extra object.

Changes:

  • Introduces a getOperationDetailsExtraFields helper in @ledgerhq/coin-aleo to whitelist which extra fields to display.
  • Adds a desktop Aleo OperationDetailsExtra component that renders only the whitelisted fields with i18n labels.
  • Adds unit/UI tests plus a new desktop i18n label for functionId, and includes a changeset.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
libs/coin-modules/coin-aleo/src/types/logic.ts Adds OperationDetailsExtraField type (currently introduces a cycle via a new type import).
libs/coin-modules/coin-aleo/src/logic/utils.ts Adds getOperationDetailsExtraFields to extract a whitelisted set of operation.extra fields.
libs/coin-modules/coin-aleo/src/logic/utils.test.ts Adds unit coverage for getOperationDetailsExtraFields.
apps/ledger-live-desktop/static/i18n/en/app.json Adds label for operationDetails.extra.functionId.
apps/ledger-live-desktop/src/renderer/families/aleo/operationDetails.tsx Adds Aleo-specific OperationDetailsExtra UI that uses the whitelist helper.
apps/ledger-live-desktop/src/renderer/families/aleo/tests/operationDetails.test.tsx Adds a desktop test asserting only functionId is rendered.
.changeset/unlucky-timers-matter.md Declares a minor bump for @ledgerhq/coin-aleo and ledger-live-desktop.

@mateuszpalosz-ext mateuszpalosz-ext force-pushed the feat/aleo-operation-details-extra branch from b57d4be to a578266 Compare March 3, 2026 14:09
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026

⚠️ E2E tests are required

Changes detected require e2e testing before merge (even before asking for any review).

🖥️ Desktop

-> Run Desktop E2E

  • Select "Run workflow"
  • Branch: feat/aleo-operation-details-extra
  • Device: nanoSP or stax

📱 Mobile

-> Run Mobile E2E

  • Select "Run workflow"
  • Branch: feat/aleo-operation-details-extra
  • Device: nanoX

Affected coins modules: aleo

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 3, 2026

@mdomanski-ext-ledger mdomanski-ext-ledger merged commit bb44747 into develop Mar 3, 2026
81 of 82 checks passed
@mdomanski-ext-ledger mdomanski-ext-ledger deleted the feat/aleo-operation-details-extra branch March 3, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

coin-modules desktop Has changes in LLD translations Translation files have been touched

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants