feat(LIVE-27029): aleo operation details extra#14914
Merged
mdomanski-ext-ledger merged 1 commit intodevelopfrom Mar 3, 2026
Merged
feat(LIVE-27029): aleo operation details extra#14914mdomanski-ext-ledger merged 1 commit intodevelopfrom
mdomanski-ext-ledger merged 1 commit intodevelopfrom
Conversation
c12704b to
604b590
Compare
604b590 to
a850966
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a family-specific renderer for Aleo operation.extra in the Operation Details drawer so only selected fields are displayed (starting with functionId), instead of showing all primitive fields from the extra object.
Changes:
- Introduces a
getOperationDetailsExtraFieldshelper in@ledgerhq/coin-aleoto whitelist whichextrafields to display. - Adds a desktop Aleo
OperationDetailsExtracomponent that renders only the whitelisted fields with i18n labels. - Adds unit/UI tests plus a new desktop i18n label for
functionId, and includes a changeset.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| libs/coin-modules/coin-aleo/src/types/logic.ts | Adds OperationDetailsExtraField type (currently introduces a cycle via a new type import). |
| libs/coin-modules/coin-aleo/src/logic/utils.ts | Adds getOperationDetailsExtraFields to extract a whitelisted set of operation.extra fields. |
| libs/coin-modules/coin-aleo/src/logic/utils.test.ts | Adds unit coverage for getOperationDetailsExtraFields. |
| apps/ledger-live-desktop/static/i18n/en/app.json | Adds label for operationDetails.extra.functionId. |
| apps/ledger-live-desktop/src/renderer/families/aleo/operationDetails.tsx | Adds Aleo-specific OperationDetailsExtra UI that uses the whitelist helper. |
| apps/ledger-live-desktop/src/renderer/families/aleo/tests/operationDetails.test.tsx | Adds a desktop test asserting only functionId is rendered. |
| .changeset/unlucky-timers-matter.md | Declares a minor bump for @ledgerhq/coin-aleo and ledger-live-desktop. |
b57d4be to
a578266
Compare
Contributor
|
|
henri-ly
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



✅ Checklist
npx changesetwas attached.📝 Description
Added custom renderer for account.extra in operation details drawer for Aleo. We want to expose only selected fields from the extra object.
❓ Context
🧐 Checklist for the PR Reviewers