Open
Conversation
Contributor
|
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the Canton “PendingTransferProposals” desktop feature by separating proposal processing, view-model logic, and presentational UI, while updating tests and adding a changeset for the desktop package.
Changes:
- Extracted transfer-proposal processing/grouping into reusable utilities.
- Introduced
usePendingTransferProposalsViewModeland aViewcomponent to decouple logic from UI. - Split table/row UI into dedicated components and refreshed unit tests accordingly.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/ledger-live-desktop/src/renderer/families/canton/PendingTransferProposals/utils/transferProposals.ts | New utilities to process raw proposals and group them by day. |
| apps/ledger-live-desktop/src/renderer/families/canton/PendingTransferProposals/usePendingTransferProposalsViewModel.ts | New hook encapsulating modal state, proposal derivation, and action handling/sync. |
| apps/ledger-live-desktop/src/renderer/families/canton/PendingTransferProposals/usePendingTransferProposalsViewModel.test.ts | New tests covering view-model behavior (sync + topology-change flow). |
| apps/ledger-live-desktop/src/renderer/families/canton/PendingTransferProposals/types.ts | Centralized types for raw/processed/grouped proposals and modal state. |
| apps/ledger-live-desktop/src/renderer/families/canton/PendingTransferProposals/index.tsx | Refactored entrypoint to render View using the new view-model hook and extracted table component. |
| apps/ledger-live-desktop/src/renderer/families/canton/PendingTransferProposals/index.test.tsx | Updated tests to validate View behavior with a view-model-shaped prop object. |
| apps/ledger-live-desktop/src/renderer/families/canton/PendingTransferProposals/components/ProposalsTable.tsx | New presentational table component for grouped proposals. |
| apps/ledger-live-desktop/src/renderer/families/canton/PendingTransferProposals/components/ProposalRow.tsx | New presentational row component rendering proposal details/actions. |
| .changeset/unlucky-pianos-smash.md | Adds a desktop changeset entry for the refactor. |
...ive-desktop/src/renderer/families/canton/PendingTransferProposals/utils/transferProposals.ts
Outdated
Show resolved
Hide resolved
...-desktop/src/renderer/families/canton/PendingTransferProposals/components/ProposalsTable.tsx
Outdated
Show resolved
Hide resolved
...ive-desktop/src/renderer/families/canton/PendingTransferProposals/components/ProposalRow.tsx
Outdated
Show resolved
Hide resolved
apps/ledger-live-desktop/src/renderer/families/canton/PendingTransferProposals/index.test.tsx
Outdated
Show resolved
Hide resolved
amaslakov
previously approved these changes
Mar 2, 2026
...ive-desktop/src/renderer/families/canton/PendingTransferProposals/components/ProposalRow.tsx
Outdated
Show resolved
Hide resolved
...ive-desktop/src/renderer/families/canton/PendingTransferProposals/components/ProposalRow.tsx
Outdated
Show resolved
Hide resolved
f029ef9 to
fdd9f36
Compare
...ive-desktop/src/renderer/families/canton/PendingTransferProposals/utils/transferProposals.ts
Outdated
Show resolved
Hide resolved
...ive-desktop/src/renderer/families/canton/PendingTransferProposals/utils/transferProposals.ts
Outdated
Show resolved
Hide resolved
...ledger-live-desktop/src/renderer/families/canton/PendingTransferProposals/DeviceAppModal.tsx
Show resolved
Hide resolved
5540b47 to
9054a91
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




✅ Checklist
npx changesetwas attached.📝 Description
Refactor PendingTransferProposals desktop components
❓ Context
🧐 Checklist for the PR Reviewers