[LWDM] feat(LIVE-29441): add wallet quote global outcomes#17336
Merged
philipptpunkt merged 1 commit intoJun 1, 2026
Conversation
This was referenced May 11, 2026
live-github-bot
Bot
added
common
live-github-bot
Bot
changed the title
Contributor
|
Contributor
Web Tools Build Status
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Wallet API swap-quote contracts and wallet-side quote pipeline to introduce standardized “global outcome” error codes, align provider error codes with a shared enum, and adjust quote fetching behavior to match legacy “no quotes” semantics on non-OK HTTP responses.
Changes:
- Re-export and adopt new
ProviderErrorCodes/QuotesErrorCodesenums for provider errors and batch-level (“global”) quote outcomes. - Update wallet-side types and logic to use these enums (notably
computeQuotesErrors) and adjust tests accordingly. - Change
fetchQuotesto return an empty result on Axios HTTP errors (non-2xx responses) while still rethrowing cancellations and non-HTTP failures.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| libs/ledger-live-common/src/wallet-api/Exchange/quotes/types.ts | Re-exports new provider/global outcome enums from the exchange module package. |
| libs/ledger-live-common/src/wallet-api/Exchange/quotes/service/types.ts | Tightens RawQuoteError.code typing to include ProviderErrorCodes. |
| libs/ledger-live-common/src/wallet-api/Exchange/quotes/service/fetchQuotes.ts | Swallows non-OK HTTP Axios responses into { rawQuotes: [], providerErrors: [] }. |
| libs/ledger-live-common/src/wallet-api/Exchange/quotes/service/fetchQuotes.test.ts | Adds unit coverage for the new HTTP-error and cancel/network error behaviors. |
| libs/ledger-live-common/src/wallet-api/Exchange/quotes/normalizer/normalizeQuote.ts | Removes deprecated single warning/error fields from normalized quote output. |
| libs/ledger-live-common/src/wallet-api/Exchange/quotes/normalizer/normalizeQuote.test.ts | Updates assertions to only use warnings[] / errors[]. |
| libs/ledger-live-common/src/wallet-api/Exchange/quotes/getQuotes.test.ts | Updates expectations to use QuotesErrorCodes and provider error enums. |
| libs/ledger-live-common/src/wallet-api/Exchange/quotes/computeQuotesErrors.ts | Uses enums for noQuotes / amount bounds outcomes and for provider error matching. |
| libs/ledger-live-common/src/wallet-api/Exchange/quotes/computeQuotesErrors.test.ts | Updates tests to the new enum-based outcome codes and adds invalid-bound coverage. |
| libs/exchange-module/src/types.ts | Removes deprecated Quote.warning/Quote.error fields; introduces new enums and updates error types. |
Contributor
Rsdoctor Bundle Diff AnalysisFound 7 projects in monorepo, 7 projects with changes. 📊 Quick Summary
📋 Detailed Reports (Click to expand)📁 desktop-mainPath:
📁 desktop-preloaderPath:
📁 desktop-rendererPath:
📁 desktop-webviewDappPreloaderPath:
📁 desktop-webviewPreloaderPath:
📁 desktop-workersPath:
📁 mobilePath:
Generated by Rsdoctor GitHub Action |
philipptpunkt
force-pushed
the
feat/LIVE-29441-wallet-quote-warnings
branch
from
99047a7 to
8af63d1
Compare
philipptpunkt
force-pushed
the
feat/LIVE-29441-wallet-quote-global-outcomes
branch
from
18b8f5a to
c44d199
Compare
philipptpunkt
force-pushed
the
feat/LIVE-29441-wallet-quote-warnings
branch
from
8af63d1 to
90cf2a3
Compare
philipptpunkt
force-pushed
the
feat/LIVE-29441-wallet-quote-global-outcomes
branch
from
c44d199 to
2275160
Compare
philipptpunkt
force-pushed
the
feat/LIVE-29441-wallet-quote-warnings
branch
from
90cf2a3 to
76860ca
Compare
philipptpunkt
force-pushed
the
feat/LIVE-29441-wallet-quote-global-outcomes
branch
from
2275160 to
459720c
Compare
philipptpunkt
force-pushed
the
feat/LIVE-29441-wallet-quote-warnings
branch
from
76860ca to
5a297f9
Compare
philipptpunkt
force-pushed
the
feat/LIVE-29441-wallet-quote-global-outcomes
branch
from
459720c to
93534d7
Compare
philipptpunkt
force-pushed
the
feat/LIVE-29441-wallet-quote-warnings
branch
from
5a297f9 to
60564b1
Compare
philipptpunkt
force-pushed
the
feat/LIVE-29441-wallet-quote-global-outcomes
branch
from
93534d7 to
f23d548
Compare
philipptpunkt
force-pushed
the
feat/LIVE-29441-wallet-quote-warnings
branch
from
60564b1 to
d79b8b5
Compare
philipptpunkt
force-pushed
the
feat/LIVE-29441-wallet-quote-warnings
branch
2 times, most recently
from
439d8a2 to
92c91db
Compare
philipptpunkt
force-pushed
the
feat/LIVE-29441-wallet-quote-global-outcomes
branch
from
a2481a2 to
4f8953a
Compare
philipptpunkt
force-pushed
the
feat/LIVE-29441-wallet-quote-warnings
branch
from
92c91db to
4160842
Compare
philipptpunkt
force-pushed
the
feat/LIVE-29441-wallet-quote-global-outcomes
branch
from
4f8953a to
32305f4
Compare
Comment on lines
+53
to
+57
| const currencyIds = [input.sendCurrencyId, input.receiveCurrencyId]; | ||
| for (const rule of VERSION_COMPATIBILITY_RULES) { | ||
| const requiredVersion = appVersion.platform === "lld" ? rule.lld : rule.llm; | ||
| if (!requiredVersion || compareVersions(appVersion.version, requiredVersion) >= 0) { | ||
| continue; |
Contributor
Author
There was a problem hiding this comment.
won't change anything here for now, since this whole check is currently under investigation with a potential removal
philipptpunkt
force-pushed
the
feat/LIVE-29441-wallet-quote-global-outcomes
branch
from
32305f4 to
37479da
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
philipptpunkt
force-pushed
the
feat/LIVE-29441-wallet-quote-global-outcomes
branch
from
37479da to
ee11db6
Compare
Comment on lines
+73
to
+77
| const response = await axios.get(url, { | ||
| params: searchParams, | ||
| headers: requestHeaders, | ||
| signal, | ||
| }); |
Contributor
Author
There was a problem hiding this comment.
This won't work with dynamic BE urls. This is further more the current common implementation in LW.
Comment on lines
63
to
+67
| deviceModelId?: string; | ||
| appVersion?: { | ||
| platform: QuotesAppPlatform; | ||
| version: string | null; | ||
| }; |
Contributor
Author
There was a problem hiding this comment.
Docs were in fact updated ✅
Comment on lines
397
to
+398
| providerErrors: QuoteProviderError[]; | ||
| warnings: QuotesWarning[]; |
Contributor
Author
There was a problem hiding this comment.
I'd rather think about removing comments from types, since the type should explain itself. Won't change this here...
philipptpunkt
force-pushed
the
feat/LIVE-29441-wallet-quote-global-outcomes
branch
from
ee11db6 to
368bde4
Compare
philipptpunkt
force-pushed
the
feat/LIVE-29441-wallet-quote-global-outcomes
branch
from
368bde4 to
5210095
Compare
|
philipptpunkt
commented
Jun 1, 2026
| llm: string | null; | ||
| }; | ||
|
|
||
| const VERSION_COMPATIBILITY_RULES: VersionCompatibilityRule[] = [ |
Contributor
Author
There was a problem hiding this comment.
Currently hardcoded just to be aligned with current Swap - but this can most likely be removed. If necessary in the future this should be handled with a remote-config / feature flag like it is done in Swap live-app.
Comment on lines
+53
to
+57
| const currencyIds = [input.sendCurrencyId, input.receiveCurrencyId]; | ||
| for (const rule of VERSION_COMPATIBILITY_RULES) { | ||
| const requiredVersion = appVersion.platform === "lld" ? rule.lld : rule.llm; | ||
| if (!requiredVersion || compareVersions(appVersion.version, requiredVersion) >= 0) { | ||
| continue; |
Contributor
Author
There was a problem hiding this comment.
won't change anything here for now, since this whole check is currently under investigation with a potential removal
qperrot
approved these changes
Jun 1, 2026
liviuciulinaru
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: https://ledgerhq.atlassian.net/browse/LIVE-29445
Description:
Add Error handling for local and global errors in the Wallet Quotes logic
Stack (managed by stac-man)