Skip to content

[LWM] Staking/Unstaking e2e tests#18901

Open
amaslakov wants to merge 2 commits into
LIVE-32928-tezos-lwd-staking-unstaking-e-2-e-testsfrom
LIVE-32929-tezos-lwm-staking-unstaking-e-2-e-tests
Open

[LWM] Staking/Unstaking e2e tests#18901
amaslakov wants to merge 2 commits into
LIVE-32928-tezos-lwd-staking-unstaking-e-2-e-testsfrom
LIVE-32929-tezos-lwm-staking-unstaking-e-2-e-tests

Conversation

@amaslakov

@amaslakov amaslakov commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
  • Test-id-only app change on the Tezos staking-section rows — no behaviour/UI change.
  • New specs need seed state: index 0 funded+undelegated, index 1 delegated+staked (≥0.005).
  • No new dependencies.

📝 Description

Mobile (Detox) e2e for Tezos staking (llmTezosStaking), mirroring desktop LIVE-32928. Five Speculos-signed specs: earning-choice, stake, unstake, and the change-validator / end-delegation "unstake required" guards.

App-source change is test-id only: the staking-section rows shared one tezos-delegation-row testID; they now expose tezos-staking-row / tezos-unstaking-row / tezos-delegation-row. No behaviour change. All five pass locally.

❓ Context

  • JIRA or GitHub link: LIVE-32929
  • ADR link (if any):

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Five Detox specs (earning-choice, stake, unstake, change-validator and
end-delegation blocked) plus the staking-section row test ids they need.
@amaslakov amaslakov requested a review from a team as a code owner June 23, 2026 22:55
Copilot AI review requested due to automatic review settings June 23, 2026 22:55
@amaslakov amaslakov requested a review from a team as a code owner June 23, 2026 22:55
@live-github-bot live-github-bot Bot added the mobile Has changes in LLM label Jun 23, 2026
@live-github-bot live-github-bot Bot changed the title [TEZOS][LWM] Staking/Unstaking e2e tests [LWM] Staking/Unstaking e2e tests Jun 23, 2026
@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Web Tools Build Status

Build Status Deployment
Web Tools Build ⏭️ Skipped
Native Storybook Build ⏭️ Skipped
React Storybook Build ⏭️ Skipped

@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

⚠️ E2E tests are required

Changes detected require e2e testing before merge (even before asking for any review).

📱 Mobile

-> Run Mobile E2E

  • Select "Run workflow"
  • Branch: LIVE-32929-tezos-lwm-staking-unstaking-e-2-e-tests
  • Device: nanoX

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds Ledger Live Mobile (Detox) end-to-end coverage for the Tezos staking/unstaking flows behind the llmTezosStaking feature flag, and introduces distinct testIDs in the Tezos account “staking section” rows to make those flows reliably targetable from e2e.

Changes:

  • Add 5 new Tezos staking-related Detox specs (earning choice, stake, unstake, and two “unstake required” guard specs).
  • Introduce a dedicated TezosStakePage page object and wire it into the e2e Application.
  • Add distinct testIDs for Tezos staking-section rows (tezos-staking-row, tezos-unstaking-row, while keeping delegation row defaulting to tezos-delegation-row).

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
e2e/mobile/specs/stake/earnChoiceTEZOS.spec.ts Adds earning-choice routing e2e spec for Tezos (undelegated seed).
e2e/mobile/specs/stake/stakeTEZOS.spec.ts Adds Tezos stake flow e2e spec (delegated+staked seed).
e2e/mobile/specs/stake/unstakeTEZOS.spec.ts Adds Tezos unstake flow e2e spec (delegated+staked seed).
e2e/mobile/specs/stake/changeValidatorBlockedTEZOS.spec.ts Adds “change validator blocked while staked” guard e2e spec.
e2e/mobile/specs/stake/endDelegationBlockedTEZOS.spec.ts Adds “end delegation blocked while staked” guard e2e spec.
e2e/mobile/specs/stake/stake.ts Shared Tezos staking/unstaking test runner utilities (init, navigation, flows).
e2e/mobile/page/trade/tezosStake.page.ts New page object encapsulating Tezos stake/unstake/guard interactions.
e2e/mobile/page/index.ts Registers tezosStake page in the e2e Application container.
apps/ledger-live-mobile/src/families/tezos/Delegations/Row.tsx Makes Tezos DelegationRow accept a configurable testID (default preserved).
apps/ledger-live-mobile/src/families/tezos/Delegations/index.tsx Assigns a distinct testID to the staking row in the staking section.
apps/ledger-live-mobile/src/families/tezos/Delegations/UnstakingRow.tsx Assigns a testID to the unstaking row in the staking section.
.changeset/gentle-mangos-retire.md Records the live-mobile patch changeset for added Tezos testIDs.

@live-github-bot

live-github-bot Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Mobile Bundle Checks

Comparing de23b92 against 2f093c8.

🚀 main.ios.jsbundle bundle size decreased (60.2mb -> 59.9mb). Thanks ❤️
🚀 main.android.jsbundle bundle size decreased (60.2mb -> 59.9mb). Thanks ❤️

Desktop Bundle Checks

Comparing 644eb86 against c7b3ed7.

🚀 renderer bundle size decreased (14.7mb -> 14.6mb). Thanks ❤️

@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Rsdoctor Bundle Diff Analysis

Found 7 projects in monorepo, 7 projects with changes.

📊 Quick Summary
Project Total Size Change
desktop-main 2.6 MB -
desktop-preloader 7.1 KB -
desktop-renderer 81.2 MB -
desktop-webviewDappPreloader 36.9 KB -
desktop-webviewPreloader 200.0 B -
desktop-workers 36.8 KB -
mobile 257.3 MB -
📋 Detailed Reports (Click to expand)

📁 desktop-main

Path: rsdoctor/desktop-main/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 2.6 MB - -
📄 JavaScript 2.4 MB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 135.3 KB - -

📁 desktop-preloader

Path: rsdoctor/desktop-preloader/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 7.1 KB - -
📄 JavaScript 5.3 KB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 1.8 KB - -

📁 desktop-renderer

Path: rsdoctor/desktop-renderer/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 81.2 MB - -
📄 JavaScript 28.9 MB - -
🎨 CSS 172.6 KB - -
🌐 HTML 1.8 KB - -
📁 Other Assets 52.2 MB - -

📁 desktop-webviewDappPreloader

Path: rsdoctor/desktop-webviewDappPreloader/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 36.9 KB - -
📄 JavaScript 36.9 KB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 desktop-webviewPreloader

Path: rsdoctor/desktop-webviewPreloader/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 200.0 B - -
📄 JavaScript 200.0 B - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 desktop-workers

Path: rsdoctor/desktop-workers/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 36.8 KB - -
📄 JavaScript 36.8 KB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 mobile

Path: rsdoctor/mobile/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 257.3 MB - -
📄 JavaScript 108.1 MB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 149.2 MB - -

Generated by Rsdoctor GitHub Action

Suffix with position.uid so repeated unstaking rows are not ambiguous to Detox.
Copilot AI review requested due to automatic review settings June 24, 2026 10:25
@live-github-bot live-github-bot Bot added the common Has changes in live-common label Jun 24, 2026
@live-github-bot live-github-bot Bot changed the title [LWM] Staking/Unstaking e2e tests [LWDM] Staking/Unstaking e2e tests Jun 24, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

Comment on lines 24 to 29
return (
<DelegationRow
testID={`tezos-unstaking-row-${position.uid}`}
baker={baker}
address={address}
amount={position.amount}
@amaslakov amaslakov force-pushed the LIVE-32929-tezos-lwm-staking-unstaking-e-2-e-tests branch from 3ca5d20 to fb46bf1 Compare June 24, 2026 22:02
@live-github-bot live-github-bot Bot removed the common Has changes in live-common label Jun 24, 2026
@live-github-bot live-github-bot Bot changed the title [LWDM] Staking/Unstaking e2e tests [LWM] Staking/Unstaking e2e tests Jun 24, 2026
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mobile Has changes in LLM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants