[LIVE-2649] Feature: Update NFT Media architecture#373
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
🦋 Changeset detectedLatest commit: 44d62e7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No changeset yet cause we're still targeting the LLM 3.3 release branch as the NFT Medias have been merged in it and versionning is then incorrect for now |
Screenshots: ✅
There are no changes in the screenshots for this PR. If this is expected, you are good to go. |
7e95a77 to
f065479
Compare
f065479 to
9164171
Compare
Codecov Report
@@ Coverage Diff @@
## release #373 +/- ##
========================================
Coverage 47.89% 47.89%
========================================
Files 605 605
Lines 26738 26738
Branches 6862 6862
========================================
Hits 12806 12806
Misses 13876 13876
Partials 56 56
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
📝 Description
Update the NFT media architecture to remove the child to parent communication
❓ Context
ledger-live-mobilehttps://ledgerhq.atlassian.net/browse/LIVE-2649✅ Checklist
📸 Demo
Ok so by order of NFT apparition:
Simulator.Screen.Recording.-.iPhone.13.-.2022-06-16.at.13.53.57.mp4
andro.mp4
🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.