Skip to content

[LIVE-2649] Feature: Update NFT Media architecture#373

Merged
hzheng-ledger merged 4 commits into
releasefrom
feat/update-nft-media-architecture
Jul 5, 2022
Merged

[LIVE-2649] Feature: Update NFT Media architecture#373
hzheng-ledger merged 4 commits into
releasefrom
feat/update-nft-media-architecture

Conversation

@lambertkevin

@lambertkevin lambertkevin commented Jun 16, 2022

Copy link
Copy Markdown
Contributor

📝 Description

Update the NFT media architecture to remove the child to parent communication

❓ Context

  • Impacted projects: ledger-live-mobile
  • Linked resource(s): https://ledgerhq.atlassian.net/browse/LIVE-2649

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

Ok so by order of NFT apparition:

  1. NFT GIF with non functionnal "big" version ✅ :
    • Fallback from NftImage "big" src to NftImage "preview" src
  2. NFT Video without any functionnal version ✅ :
    • Fallback from NftVideo "big" src to NftImage "preview" src
    • NftImage has an error on "preview" src as well
    • Show the NoftFound image since no media has been working
  3. NFT Video with every functionnal version ✅ :
    • NftVideo works correctly with "big" src
  4. NFT GIF with every functionnal version ✅ :
    • NftImage works correctly with "big" src
Simulator.Screen.Recording.-.iPhone.13.-.2022-06-16.at.13.53.57.mp4
andro.mp4

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel

vercel Bot commented Jun 16, 2022

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Jul 5, 2022 at 11:07PM (UTC)
native-ui-storybook ✅ Ready (Inspect) Visit Preview Jul 5, 2022 at 11:07PM (UTC)
react-ui-storybook ✅ Ready (Inspect) Visit Preview Jul 5, 2022 at 11:07PM (UTC)
1 Ignored Deployment
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Jul 5, 2022 at 11:07PM (UTC)

@changeset-bot

changeset-bot Bot commented Jun 16, 2022

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 44d62e7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added the mobile Has changes in LLM label Jun 16, 2022
@lambertkevin

lambertkevin commented Jun 16, 2022

Copy link
Copy Markdown
Contributor Author

No changeset yet cause we're still targeting the LLM 3.3 release branch as the NFT Medias have been merged in it and versionning is then incorrect for now

@lambertkevin lambertkevin added the HODL Do not merge label Jun 16, 2022
@lambertkevin lambertkevin marked this pull request as ready for review June 16, 2022 12:57
@lambertkevin lambertkevin requested a review from gre June 16, 2022 12:57
@github-actions

github-actions Bot commented Jun 16, 2022

Copy link
Copy Markdown
Contributor

@hzheng-ledger

Screenshots: ✅

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

Comment thread apps/ledger-live-mobile/src/components/Nft/NftVideo.tsx Outdated
Base automatically changed from release to main June 24, 2022 08:42
@lambertkevin lambertkevin changed the base branch from main to develop June 30, 2022 08:44
@codecov

codecov Bot commented Jun 30, 2022

Copy link
Copy Markdown

Codecov Report

Merging #373 (44d62e7) into release (a9e33dc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           release     #373   +/-   ##
========================================
  Coverage    47.89%   47.89%           
========================================
  Files          605      605           
  Lines        26738    26738           
  Branches      6862     6862           
========================================
  Hits         12806    12806           
  Misses       13876    13876           
  Partials        56       56           
Flag Coverage Δ
test 47.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9e33dc...44d62e7. Read the comment docs.

@hzheng-ledger hzheng-ledger changed the base branch from develop to release July 5, 2022 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature ready mobile Has changes in LLM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants