Skip to content

Fix LLM: 2 firmware update banners being displayed on the wallet screen#374

Merged
OlivierFreyssinet merged 4 commits into
developfrom
bugfix/fw-update-double-banner
Jul 6, 2022
Merged

Fix LLM: 2 firmware update banners being displayed on the wallet screen#374
OlivierFreyssinet merged 4 commits into
developfrom
bugfix/fw-update-double-banner

Conversation

@OlivierFreyssinet

@OlivierFreyssinet OlivierFreyssinet commented Jun 16, 2022

Copy link
Copy Markdown
Contributor

📝 Description

The firmware banner is being displayed twice on the wallet screen:
Screenshot 2022-06-16 at 14 43 18

❓ Context

  • Impacted projects: ledger-live-mobile
  • Linked resource(s): LIVE-2682

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

Screenshot 2022-06-16 at 14 45 00

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@OlivierFreyssinet OlivierFreyssinet self-assigned this Jun 16, 2022
@changeset-bot

changeset-bot Bot commented Jun 16, 2022

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 0e383d1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Jun 16, 2022

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ledger-live-github-bot ✅ Ready (Inspect) Visit Preview Jul 6, 2022 at 4:21PM (UTC)
live-common-tools ✅ Ready (Inspect) Visit Preview Jul 6, 2022 at 4:21PM (UTC)
native-ui-storybook ✅ Ready (Inspect) Visit Preview Jul 6, 2022 at 4:21PM (UTC)
react-ui-storybook ✅ Ready (Inspect) Visit Preview Jul 6, 2022 at 4:21PM (UTC)

@github-actions github-actions Bot added automation CI/CD stuff cli common Has changes in live-common desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM translations Translation files have been touched ui Has changes in the design system library labels Jun 16, 2022
@OlivierFreyssinet OlivierFreyssinet changed the base branch from develop to release June 16, 2022 12:56

@ThomasLaforge ThomasLaforge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch !

@OlivierFreyssinet OlivierFreyssinet force-pushed the bugfix/fw-update-double-banner branch from 4d97e2b to 111160d Compare June 17, 2022 13:33
@github-actions github-actions Bot removed ledgerjs Has changes in the ledgerjs open source libs desktop Has changes in LLD common Has changes in live-common cli automation CI/CD stuff translations Translation files have been touched ui Has changes in the design system library labels Jun 17, 2022
@github-actions

github-actions Bot commented Jun 17, 2022

Copy link
Copy Markdown
Contributor

@ofreyssinet-ledger

Screenshots: ✅

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@ychen-ledger ychen-ledger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated with:

  • LLM 3.3.0-next.8(524574)
  • Pixel 4 Android 12/iPhone 11 iOS 14.7
  • Nano X

Base automatically changed from release to main June 24, 2022 08:42
@LFBarreto LFBarreto changed the base branch from main to develop June 27, 2022 08:36
@codecov

codecov Bot commented Jul 6, 2022

Copy link
Copy Markdown

Codecov Report

Merging #374 (f1d7f20) into develop (d1a2aae) will increase coverage by 0.29%.
The diff coverage is n/a.

❗ Current head f1d7f20 differs from pull request most recent head 0e383d1. Consider uploading reports for the commit 0e383d1 to get more accurate results

@@             Coverage Diff             @@
##           develop     #374      +/-   ##
===========================================
+ Coverage    47.68%   47.98%   +0.29%     
===========================================
  Files          604      607       +3     
  Lines        26698    26954     +256     
  Branches      6849     6897      +48     
===========================================
+ Hits         12732    12934     +202     
- Misses       13911    13960      +49     
- Partials        55       60       +5     
Flag Coverage Δ
test 47.98% <ø> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libs/ledgerjs/packages/hw-app-xrp/src/Xrp.ts 89.09% <0.00%> (ø)
libs/ledgerjs/packages/hw-app-trx/src/Trx.ts 81.94% <0.00%> (ø)
libs/ledgerjs/packages/hw-app-trx/src/utils.ts 61.40% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1a2aae...0e383d1. Read the comment docs.

@OlivierFreyssinet OlivierFreyssinet merged commit 443696c into develop Jul 6, 2022
@OlivierFreyssinet OlivierFreyssinet deleted the bugfix/fw-update-double-banner branch July 6, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mobile Has changes in LLM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants