LLM - New Card button and removed two other ones by mle-gall · Pull Request #466 · LedgerHQ/ledger-live

mle-gall · 2022-06-24T14:27:57Z

…drawer New Card button in the header of the portfolio + tracking

📝 Description

Removed Card CTA's under the graph (purple) and in the quick actions drawer
New Card button in the header of the portfolio + tracking

❓ Context

Impacted projects: LLM
Linked resource(s): LIVE-2633

✅ Checklist

Test coverage
Atomic delivery
No breaking changes

📸 Demo

Screen_Recording_20220623-153422_LL.DEV.mp4

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

vercel · 2022-06-24T14:27:59Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
live-common-tools	✅ Ready (Inspect)	Visit Preview	Jun 29, 2022 at 0:21AM (UTC)

3 Ignored Deployments

Name	Status	Updated
ledger-live-github-bot	⬜️ Ignored (Inspect)	Jun 29, 2022 at 0:21AM (UTC)
native-ui-storybook	⬜️ Ignored (Inspect)	Jun 29, 2022 at 0:21AM (UTC)
react-ui-storybook	⬜️ Ignored (Inspect)	Jun 29, 2022 at 0:21AM (UTC)

changeset-bot · 2022-06-24T14:28:00Z

🦋 Changeset detected

Latest commit: 026d923

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
live-mobile	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2022-06-24T14:45:47Z

@mlegall-ledger

Screenshots: ✅

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

OlivierFreyssinet

LGTM 👍

codecov · 2022-06-28T13:56:57Z

Codecov Report

Merging #466 (2aa5431) into develop (907325b) will decrease coverage by 19.34%.
The diff coverage is n/a.

❗ Current head 2aa5431 differs from pull request most recent head 026d923. Consider uploading reports for the commit 026d923 to get more accurate results

@@             Coverage Diff              @@
##           develop     #466       +/-   ##
============================================
- Coverage    64.16%   44.82%   -19.35%     
============================================
  Files          634      549       -85     
  Lines        28559    23775     -4784     
  Branches      7207     6231      -976     
============================================
- Hits         18326    10657     -7669     
- Misses       10166    13070     +2904     
+ Partials        67       48       -19

Flag	Coverage Δ
bot	`?`
test	`44.82% <ø> (-2.68%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...e-common/src/families/cosmos/js-synchronisation.ts	`9.00% <0.00%> (-84.69%)`	⬇️
...dger-live-common/src/families/solana/api/queued.ts	`16.66% <0.00%> (-83.34%)`	⬇️
...bitcoin/wallet-btc/pickingstrategies/CoinSelect.ts	`8.79% <0.00%> (-82.42%)`	⬇️
...-common/src/families/bitcoin/js-synchronisation.ts	`13.14% <0.00%> (-81.72%)`	⬇️
...-common/src/families/solana/validator-app/index.ts	`18.51% <0.00%> (-81.49%)`	⬇️
.../bitcoin/wallet-btc/pickingstrategies/DeepFirst.ts	`17.94% <0.00%> (-79.49%)`	⬇️
...ger-live-common/src/families/crypto_org/api/sdk.ts	`16.85% <0.00%> (-78.66%)`	⬇️
...-common/src/families/hedera/hw-app-hedera/index.ts	`16.21% <0.00%> (-78.38%)`	⬇️
...edger-live-common/src/families/celo/hw-app-celo.ts	`3.38% <0.00%> (-77.97%)`	⬇️
...e-common/src/families/ripple/js-synchronization.ts	`21.56% <0.00%> (-76.48%)`	⬇️
... and 310 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 907325b...026d923. Read the comment docs.

…drawer New Card button in the header of the portfolio + tracking

gre · 2022-06-30T08:25:56Z

🙏 a PR must not be merged if the PR checklist is not complete, if a checkbox can't be complete because then you must explain it in the PR description, for instance you must explain why you couldn't test it and how to test it / if QA had the time to test it etc..

gre · 2022-06-30T08:27:03Z

+  const onCardButtonPress = useCallback(() => {
+    navigation.navigate(ScreenName.PlatformApp, {
+      platform: "cl-card",
+      name: "CL Card Powered by Ledger",


not translation needed on these?

Good question, I've simply reused the title as used in other parts of the app. As for the checklist, it's just an issue from my side

ychen-ledger

Validated with:

LLM 3.3.0
Android 12 pixel 4
iOS 14.7 iPhone 11

mle-gall added the mobile Has changes in LLM label Jun 24, 2022

github-actions Bot assigned mle-gall Jun 24, 2022

github-actions Bot added the translations Translation files have been touched label Jun 24, 2022

mle-gall changed the title ~~Removed Card CTA's under the graph (purple) and in the quick actions …~~ LLM - New Card button and removed two other ones Jun 24, 2022

vercel Bot deployed to Preview – live-common-tools June 24, 2022 14:31 View deployment

mle-gall requested a review from a team June 24, 2022 14:32

OlivierFreyssinet approved these changes Jun 27, 2022

View reviewed changes

LFBarreto added this to the Ledger Live Mobile 3.4.x milestone Jun 27, 2022

nparigi-ledger approved these changes Jun 27, 2022

View reviewed changes

github-actions Bot added automation CI/CD stuff common Has changes in live-common desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs tools Has changes in tools ui Has changes in the design system library labels Jun 28, 2022

vercel Bot deployed to Preview – live-common-tools June 28, 2022 13:47 View deployment

mle-gall force-pushed the feat/LIVE-2633/newCardButtonDeletedLegacy branch from 8400013 to ccf1aa6 Compare June 28, 2022 13:48

github-actions Bot removed tools Has changes in tools ledgerjs Has changes in the ledgerjs open source libs common Has changes in live-common ui Has changes in the design system library automation CI/CD stuff desktop Has changes in LLD labels Jun 28, 2022

vercel Bot deployed to Preview – live-common-tools June 28, 2022 13:49 View deployment

mle-gall changed the base branch from develop to release June 29, 2022 08:23

mle-gall changed the base branch from release to develop June 29, 2022 08:23

Removed Card CTA's under the graph (purple) and in the quick actions …

026d923

…drawer New Card button in the header of the portfolio + tracking

mle-gall force-pushed the feat/LIVE-2633/newCardButtonDeletedLegacy branch from ccf1aa6 to 026d923 Compare June 29, 2022 12:20

vercel Bot deployed to Preview – live-common-tools June 29, 2022 12:21 View deployment

mle-gall merged commit c258156 into develop Jun 29, 2022

mle-gall deleted the feat/LIVE-2633/newCardButtonDeletedLegacy branch June 29, 2022 12:50

gre reviewed Jun 30, 2022

View reviewed changes

ychen-ledger reviewed Jun 30, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LLM - New Card button and removed two other ones#466

LLM - New Card button and removed two other ones#466
mle-gall merged 1 commit into
developfrom
feat/LIVE-2633/newCardButtonDeletedLegacy

mle-gall commented Jun 24, 2022 •

edited

Loading

Uh oh!

vercel Bot commented Jun 24, 2022 •

edited

Loading

Uh oh!

changeset-bot Bot commented Jun 24, 2022 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 24, 2022 •

edited

Loading

Uh oh!

OlivierFreyssinet left a comment

Uh oh!

codecov Bot commented Jun 28, 2022 •

edited

Loading

Uh oh!

gre commented Jun 30, 2022

Uh oh!

gre Jun 30, 2022

Uh oh!

mle-gall Jun 30, 2022 •

edited

Loading

Uh oh!

ychen-ledger left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

mle-gall commented Jun 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Description

❓ Context

✅ Checklist

📸 Demo

🚀 Expectations to reach

Uh oh!

vercel Bot commented Jun 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot Bot commented Jun 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions Bot commented Jun 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OlivierFreyssinet left a comment

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Jun 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

gre commented Jun 30, 2022

Uh oh!

gre Jun 30, 2022

Choose a reason for hiding this comment

Uh oh!

mle-gall Jun 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ychen-ledger left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

mle-gall commented Jun 24, 2022 •

edited

Loading

vercel Bot commented Jun 24, 2022 •

edited

Loading

changeset-bot Bot commented Jun 24, 2022 •

edited

Loading

github-actions Bot commented Jun 24, 2022 •

edited

Loading

codecov Bot commented Jun 28, 2022 •

edited

Loading

mle-gall Jun 30, 2022 •

edited

Loading