Skip to content

Feat/LIVE-1414 RBF new implementation for Bitcoin#502

Merged
valpinkman merged 4 commits into
releasefrom
feat/LL-1414
Jun 29, 2022
Merged

Feat/LIVE-1414 RBF new implementation for Bitcoin#502
valpinkman merged 4 commits into
releasefrom
feat/LL-1414

Conversation

@hzheng-ledger

Copy link
Copy Markdown
Contributor

📝 Description

RBF new implementation

❓ Context

It is a merge of
two PRs before the monorepo:
LedgerHQ/ledger-live-desktop#4862
and
LedgerHQ/ledger-live-common#1826

Jira tickets:
https://ledgerhq.atlassian.net/browse/LIVE-1415
https://ledgerhq.atlassian.net/browse/LIVE-1416
https://ledgerhq.atlassian.net/browse/LIVE-1414

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

Screenshot: (the rbf related options and checkboxes are removed)

image

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel

vercel Bot commented Jun 28, 2022

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Jun 29, 2022 at 0:52AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Jun 29, 2022 at 0:52AM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Jun 29, 2022 at 0:52AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Jun 29, 2022 at 0:52AM (UTC)

@changeset-bot

changeset-bot Bot commented Jun 28, 2022

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 733f8e1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
ledger-live-desktop Major
@ledgerhq/live-common Major
@ledgerhq/live-cli Patch
live-mobile Patch
live-common-tools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added common Has changes in live-common desktop Has changes in LLD translations Translation files have been touched labels Jun 28, 2022
@github-actions

github-actions Bot commented Jun 28, 2022

Copy link
Copy Markdown
Contributor

@hzheng-ledger

Screenshots: ✅

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@codecov

codecov Bot commented Jun 28, 2022

Copy link
Copy Markdown

Codecov Report

Merging #502 (733f8e1) into release (75cae06) will increase coverage by 0.01%.
The diff coverage is 54.54%.

@@             Coverage Diff             @@
##           release     #502      +/-   ##
===========================================
+ Coverage    47.54%   47.56%   +0.01%     
===========================================
  Files          601      601              
  Lines        26606    26606              
  Branches      6832     6830       -2     
===========================================
+ Hits         12649    12654       +5     
+ Misses       13902    13897       -5     
  Partials        55       55              
Flag Coverage Δ
test 47.56% <54.54%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...er-live-common/src/families/bitcoin/bridge/mock.ts 74.46% <ø> (ø)
...s/ledger-live-common/src/families/bitcoin/cache.ts 34.61% <0.00%> (+1.28%) ⬆️
...ve-common/src/families/bitcoin/datasets/bitcoin.ts 100.00% <ø> (ø)
...common/src/families/bitcoin/js-buildTransaction.ts 30.43% <ø> (ø)
...ommon/src/families/bitcoin/js-createTransaction.ts 75.00% <ø> (ø)
...on/src/families/bitcoin/js-estimateMaxSpendable.ts 35.29% <ø> (+1.96%) ⬆️
...s/ledger-live-common/src/families/bitcoin/logic.ts 35.18% <0.00%> (+1.25%) ⬆️
...er-live-common/src/families/bitcoin/transaction.ts 46.15% <0.00%> (+1.15%) ⬆️
...s/ledger-live-common/src/families/bitcoin/types.ts 100.00% <ø> (ø)
...-common/src/families/bitcoin/js-synchronisation.ts 13.06% <33.33%> (-0.08%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75cae06...733f8e1. Read the comment docs.

@desirendr desirendr added this to the Ledger Live Desktop 2.44.x milestone Jun 29, 2022
@valpinkman valpinkman merged commit bdc76d7 into release Jun 29, 2022
@valpinkman valpinkman deleted the feat/LL-1414 branch June 29, 2022 14:39
valpinkman added a commit that referenced this pull request Jul 5, 2022
* release: (38 commits)
  fix changelogs
  fix changelogs
  Smartling on-demand translation delivery from release (#570)
  🚀 release prerelease [LLD(2.44.0-next.1), LLM(3.4.0-next.4)]
  add changelog to swap fix
  fix typo
  🚀 release prerelease [LLD(2.44.0-next.0), LLM(3.4.0-next.4)]
  Bugfix/fix swap tos text (#545)
  ci: add github token to prevent the changelog formatter from throwing
  Bugfix/minor swap fixes (#541)
  add missing dependencies for changelog
  clean g++ fix (#500)
  fix: changelog formatter typo
  fix: no major on LLD
  Revert ":rocket: release prerelease [LLD(3.0.0-next.5), LLM(3.4.0-next.4)]"
  fix LLD version
  :rocket: release prerelease [LLD(3.0.0-next.5), LLM(3.4.0-next.4)]
  Feat/LIVE-1414 RBF new implementation for Bitcoin (#502)
  update changelog format (#504)
  🚀 release prerelease [LLD(2.44.0-next.4), LLM(3.4.0-next.3)]
  ...
valpinkman added a commit that referenced this pull request Jul 5, 2022
* release: (136 commits)
  fix changelogs
  fix changelogs
  Smartling on-demand translation delivery from release (#570)
  🚀 release prerelease [LLD(2.44.0-next.1), LLM(3.4.0-next.4)]
  add changelog to swap fix
  fix typo
  🚀 release prerelease [LLD(2.44.0-next.0), LLM(3.4.0-next.4)]
  Bugfix/fix swap tos text (#545)
  ci: add github token to prevent the changelog formatter from throwing
  Bugfix/minor swap fixes (#541)
  add missing dependencies for changelog
  clean g++ fix (#500)
  fix: changelog formatter typo
  fix: no major on LLD
  Revert ":rocket: release prerelease [LLD(3.0.0-next.5), LLM(3.4.0-next.4)]"
  fix LLD version
  :rocket: release prerelease [LLD(3.0.0-next.5), LLM(3.4.0-next.4)]
  Feat/LIVE-1414 RBF new implementation for Bitcoin (#502)
  update changelog format (#504)
  🚀 release prerelease [LLD(2.44.0-next.4), LLM(3.4.0-next.3)]
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

common Has changes in live-common desktop Has changes in LLD translations Translation files have been touched

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants