This repository was archived by the owner on Feb 12, 2025. It is now read-only.
sha512256: patch portability.h to compile on ARM#764
Open
antichris wants to merge 2 commits intoLedgerHQ:developfrom
Open
sha512256: patch portability.h to compile on ARM#764antichris wants to merge 2 commits intoLedgerHQ:developfrom
antichris wants to merge 2 commits intoLedgerHQ:developfrom
Conversation
Intel's x86 intrinsics do not apply to ARM architectures (obviously!). This patch only enables compilation: for optimum performance architecture-specific bytecode should be implemented instead. This should probably also be backported to other branches, such as 3.5.x on which the current stable `npm` package (and, through that, Live) depends.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intel's x86 intrinsics do not apply to ARM architectures (obviously!).
This patch only enables compilation: for optimum performance architecture-specific bytecode should be implemented instead.
This should probably also be backported to other branches, such as 3.5.x on which the current stable
npmpackage (and, through that, Live) depends.