Closed
Conversation
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #541 +/- ##
=======================================
Coverage 43.38% 43.38%
=======================================
Files 125 125
Lines 12595 12595
Branches 1012 1012
=======================================
Hits 5464 5464
Misses 6796 6796
Partials 335 335 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8bebdb9 to
f188437
Compare
f188437 to
fea420a
Compare
yogh333
requested changes
Mar 21, 2025
Contributor
yogh333
left a comment
There was a problem hiding this comment.
Could you please rebase your PR 🙏
fea420a to
13159ac
Compare
Author
|
Updated the PR, also bumped python version to |
13159ac to
2de0e64
Compare
Author
|
Hello, do you know when we can merge this PR? |
Contributor
|
No more relevant, since we have migrated to pyqt6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to add pyqt5 support to be able to run speculos with qt.
Also, updated python version from
3.9to3.10to match the builder python version.WARNING: As the qt library is not very light, the image size is now 1.24GB instead of 800MB.