Skip to content

docker: Add pyqt5 dependency#541

Closed
aussedatlo wants to merge 2 commits intoLedgerHQ:masterfrom
aussedatlo:mac-qt-support
Closed

docker: Add pyqt5 dependency#541
aussedatlo wants to merge 2 commits intoLedgerHQ:masterfrom
aussedatlo:mac-qt-support

Conversation

@aussedatlo
Copy link

@aussedatlo aussedatlo commented Dec 19, 2024

This PR aims to add pyqt5 support to be able to run speculos with qt.

Also, updated python version from 3.9 to 3.10 to match the builder python version.

WARNING: As the qt library is not very light, the image size is now 1.24GB instead of 800MB.

@ledger-wiz-cspm-secret-detection
Copy link

ledger-wiz-cspm-secret-detection bot commented Dec 19, 2024

Wiz Scan Summary

Scanner Findings
Data Finding Sensitive Data
Secret Finding Secrets
IaC Misconfiguration IaC Misconfigurations 1 High 5 Medium 1 Info
Total 1 High 5 Medium 1 Info

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.38%. Comparing base (f1eb74f) to head (2de0e64).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #541   +/-   ##
=======================================
  Coverage   43.38%   43.38%           
=======================================
  Files         125      125           
  Lines       12595    12595           
  Branches     1012     1012           
=======================================
  Hits         5464     5464           
  Misses       6796     6796           
  Partials      335      335           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aussedatlo aussedatlo marked this pull request as draft January 6, 2025 08:19
@aussedatlo aussedatlo force-pushed the mac-qt-support branch 2 times, most recently from 8bebdb9 to f188437 Compare January 13, 2025 15:04
@aussedatlo aussedatlo marked this pull request as ready for review January 13, 2025 15:16
@yogh333 yogh333 self-requested a review March 21, 2025 09:01
Copy link
Contributor

@yogh333 yogh333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please rebase your PR 🙏

@aussedatlo aussedatlo marked this pull request as draft March 24, 2025 09:56
@aussedatlo aussedatlo marked this pull request as ready for review March 24, 2025 10:26
@aussedatlo
Copy link
Author

Updated the PR, also bumped python version to 9.10 to match builder version.

@aussedatlo aussedatlo requested a review from yogh333 March 24, 2025 10:27
Copy link
Contributor

@yogh333 yogh333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aussedatlo
Copy link
Author

Hello, do you know when we can merge this PR?

@cedelavergne-ledger
Copy link
Contributor

No more relevant, since we have migrated to pyqt6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants