[3주차] 조재희/[feat]Todolist 주요기능 구현#29
Open
wo-gml wants to merge 4 commits intoLeets-Official:조재희/mainfrom
Hidden character warning
The head ref may contain hidden characters: "\uc870\uc7ac\ud76c/3\uc8fc\ucc28"
Open
Conversation
j2nnif2r
reviewed
Apr 8, 2026
| const activeTasksCount = todos.filter((todo) => !todo.completed).length | ||
| const activeTasksCount = todos.filter((todo) => !todo.completed).length; | ||
|
|
||
| const todoListUI = ( |
There was a problem hiding this comment.
todoListUI를 변수로 분리해 중복을 줄인 점이 좋았습니다.
다만 해당 렌더링 로직을 별도의 컴포넌트로 분리하면 역할이 더 명확해지고 재사용성도 높아질 것 같습니다!
sd091415
reviewed
Apr 8, 2026
sd091415
left a comment
There was a problem hiding this comment.
현재 useNavigate를 사용하고 계신데 NavLink를 사용한다면 Button.jsx에서의 TailwindCSS 코드도 더 깔끔하게 정리 할 수 있을 거 같습니다.
|
상태를 변경할때 prev를 활용한 함수형 업데이트를 사용하여 비동기적으로 여러번의 상태변경이 발생할때 이전 상태가 참조되는 문제를 해결해 안정적으로 동작하는 코드인 것 같습니다. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. 과제 요구사항 중 구현한 내용
2. 핵심 변경 사항
3. 실행 및 검증 결과
npm run dev로 정상 실행됨. ESLint 오류 없음, 빌드 성공 (npm run build).4. 완료 사항
5. 추가 사항
closed #28제출 체크리스트
{이름}/main브랜치다{이름}/{숫자}주차브랜치다Reviewer가 참고할 내용