[Feat] Profile 컴포넌트 개발 및 디자인 #18
Merged
Hidden character warning
The head ref may contain hidden characters: "17-feat/Priofile-\ucef4\ud3ec\ub10c\ud2b8-\uc81c\uc791"
Merged
Conversation
PR 검증 결과✅ TypeScript: 통과 |
YeBeenChoi
reviewed
Jan 13, 2026
Comment on lines
+12
to
+15
| <div | ||
| className={profileVariants({ size, className })} | ||
| style={imageUrl ? { backgroundImage: `url(${imageUrl})` } : undefined} | ||
| {...props} |
Collaborator
There was a problem hiding this comment.
...props에 style이 포함될 수 있어서 외부에서 style을 넘기는 경우 backgroundImage가 덮일 수 있을 것 같아요!
Collaborator
Author
There was a problem hiding this comment.
해당 내용 몰랐는데, 말씀해주신 부분 반영해서,
style prop을 분리해 imageUrl에서 설정한 backgroundImage와 외부 style 간의 우선순위가 명확해지도록 수정했습니다.!
PR 검증 결과✅ TypeScript: 통과 |
PR 검증 결과✅ TypeScript: 통과 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ 주요 변경사항
📝 작업 상세 내용
✅ 체크리스트
Close #번호추가📸 스크린샷 (선택)
🔍 기타 참고사항
🔗 관련 이슈