[Feat] Header 컴포넌트 제작#20
Merged
Hidden character warning
The head ref may contain hidden characters: "19-feat/Header-\ucef4\ud3ec\ub10c\ud2b8-\uc81c\uc791"
Merged
Conversation
PR 검증 결과✅ TypeScript: 통과 |
- CodeQL 정적 분석 워크플로우 추가 - PR 설명 누락 시 코멘트 알림 워크플로우 추가 - 기존 워크플로우에 concurrency 설정 추가
PR 검증 결과✅ TypeScript: 통과 |
PR 검증 결과✅ TypeScript: 통과 |
jwj0620gcu
approved these changes
Jan 14, 2026
|
|
||
| const { base, rightSection, innerSection, navItem } = headerVariants(); | ||
|
|
||
| const NAV_ITEMS = [ |
Collaborator
There was a problem hiding this comment.
item을 직접 작성하는 방식에 익숙했는데, 이번 코드처럼 nav item을 배열로 분리해서 map으로 렌더링하는게
확장성에서 더 좋은 방법인 것 같습니다!
YeBeenChoi
approved these changes
Jan 14, 2026
YeBeenChoi
left a comment
YeBeenChoi
left a comment
Collaborator
There was a problem hiding this comment.
코드가 깔끔한 것 같아요... 👍 고생 많으셨습니다!
|
|
||
| const { base, rightSection, innerSection, navItem } = headerVariants(); | ||
|
|
||
| const NAV_ITEMS = [ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ 주요 변경사항
📝 작업 상세 내용
✅ 체크리스트
Close #번호추가📸 스크린샷 (선택)
🔍 기타 참고사항
🔗 관련 이슈